Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Session gets expired using AJAX with Session #3546

Merged
merged 1 commit into from
Aug 27, 2020

Conversation

crustamet
Copy link
Contributor

Fix session class setcookie not getting renewed when using ajax and put expire date in the past.

Each pull request should address a single issue and have a meaningful title.

Description
Explain what you have changed, and why.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

---------Remove from here down in your description----------

Notes

  • Pull requests must be in English
  • If the PR solves an issue, reference it with a suitable verb and the issue number
    (e.g. fixes 12345)
  • Unsolicited pull requests will be considered, but there is no guarantee of acceptance
  • Pull requests should be from a feature branch in the contributor's fork of the repository
    to the develop branch of the project repository

Fix session class setcookie not getting renewed when using ajax and put expire date in the past.
@michalsn
Copy link
Member

Thank you for your first PR!

I will merge this in this shape since from what I understand these changes were made via the web interface. Not sure if there is an option to rebase.

I will add more tests for this in next PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants