-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Model::first() only use orderBy() when group by is not empty #2907
Merged
lonnieezell
merged 13 commits into
codeigniter4:develop
from
samsonasik:bug-fix-first-group-by
May 1, 2020
Merged
Fix Model::first() only use orderBy() when group by is not empty #2907
lonnieezell
merged 13 commits into
codeigniter4:develop
from
samsonasik:bug-fix-first-group-by
May 1, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsonasik
force-pushed
the
bug-fix-first-group-by
branch
from
April 30, 2020 20:11
aa9b85e
to
31ce7de
Compare
samsonasik
force-pushed
the
bug-fix-first-group-by
branch
from
April 30, 2020 20:50
c01f554
to
7d515e5
Compare
It seems "group by" resetted on query builder limit call. it require a deep check. |
samsonasik
changed the title
Fix Model::first() only use orderBy() when group by is not empty
[wip] Fix Model::first() only use orderBy() when group by is not empty
Apr 30, 2020
samsonasik
changed the title
[wip] Fix Model::first() only use orderBy() when group by is not empty
Fix Model::first() only use orderBy() when group by is not empty
May 1, 2020
Fixed. On |
It seems not really working if |
added check force group by only when Model::useSoftDeletes is true with withDeleted() call. |
travis build green 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix the condition, eg: in Postgresql when we can supply sql like:
without group by, and followed order by. So, make order by only when there is a group by.
Checklist: