clean up testFirstAggregate

codeigniter4 · Apr 30, 2020 · c01f554 · c01f554
1 parent 0d272bb
commit c01f554
Showing 1 changed file with 9 additions and 7 deletions.
diff --git a/tests/system/Database/Live/ModelTest.php b/tests/system/Database/Live/ModelTest.php
@@ -268,17 +268,19 @@ public function testFirstAggregate($groupBy)
 
 		if ($groupBy)
 		{
-			$user = $model->select('SUM(id) as total')
-						->where('id >', 2)
-						->groupBy('id')
-						->first();
+			$model->groupBy('id');
+		}
+
+		$user = $model->select('SUM(id) as total')
+					  ->where('id >', 2)
+					  ->first();
+
+		if ($groupBy)
+		{
 			$this->assertEquals(3, $user->total);
 		}
 		else
 		{
-			$user = $model->select('SUM(id) as total')
-						->where('id >', 2)
-						->first();
 			$this->assertEquals(7, $user->total);
 		}
 	}