Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix drop column with array #2578

Merged
merged 1 commit into from
Feb 21, 2020
Merged

Fix drop column with array #2578

merged 1 commit into from
Feb 21, 2020

Conversation

musmanikram
Copy link
Contributor

@musmanikram musmanikram commented Feb 19, 2020 •
edited
Loading

Fix issue #2576

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@musmanikram musmanikram force-pushed the 2576-fix-multi-column-drop branch 4 times, most recently from 8e8f761 to 3d745cb Compare February 19, 2020 23:35
@lonnieezell
Copy link
Member

I like the concept. Tests are failing and need to be fixed up. Also needs documentation update.

@musmanikram musmanikram force-pushed the 2576-fix-multi-column-drop branch 5 times, most recently from 39716e2 to a109a55 Compare February 20, 2020 21:12
@musmanikram musmanikram force-pushed the 2576-fix-multi-column-drop branch from a109a55 to 0e13f38 Compare February 20, 2020 22:55
@lonnieezell lonnieezell merged commit b55dddc into codeigniter4:develop Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lonnieezell lonnieezell Awaiting requested review from lonnieezell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@musmanikram @lonnieezell