Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: $forge->dropColumn not allowing arrays #2576

Closed
MohKari opened this issue Feb 19, 2020 · 1 comment
Closed

Bug: $forge->dropColumn not allowing arrays #2576

MohKari opened this issue Feb 19, 2020 · 1 comment
Labels
bug Verified issues on the current code behavior or pull requests that will fix them

Comments

@MohKari
Copy link
Contributor

MohKari commented Feb 19, 2020

Describe the bug
According to the documentation here, the dropColumn method should allow for an array of columns to be dropped. However the method only allows for a string, and the logic doesn't handle the possibility of an array been supplied.

CodeIgniter 4 version
4.0.0:master

Affected module(s)
CodeIgniter\Database\Forge

Expected behavior, and steps to reproduce if appropriate
Be allowed to supply either a string or an array, and either a single or multiple columns are dropped.

Context

  • OS: 4.9.184-linuxkit
  • Web server Apache/2.4.38 (Debian)
  • PHP version 7.2.22
@MohKari MohKari added the bug Verified issues on the current code behavior or pull requests that will fix them label Feb 19, 2020
@musmanikram musmanikram mentioned this issue Feb 19, 2020
Merged
5 tasks
@musmanikram
Copy link
Contributor

@lonnieezell please close this issue

@MGatner MGatner closed this as completed Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@musmanikram @MGatner @MohKari