Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML Helper - Fix attribute type for lists #2516

Merged
merged 1 commit into from
Jan 27, 2020
Merged

HTML Helper - Fix attribute type for lists #2516

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions system/Helpers/html_helper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,11 +51,11 @@
* Generates an HTML unordered list from an single or
* multi-dimensional array.
*
* @param array $list
* @param string $attributes HTML attributes
* @param array $list
* @param mixed $attributes HTML attributes string, array, object
* @return string
*/
function ul(array $list, string $attributes = ''): string
function ul(array $list, $attributes = ''): string
{
return _list('ul', $list, $attributes);
}
Expand All @@ -70,11 +70,11 @@ function ul(array $list, string $attributes = ''): string
*
* Generates an HTML ordered list from an single or multi-dimensional array.
*
* @param array $list
* @param string $attributes HTML attributes
* @param array $list
* @param mixed $attributes HTML attributes string, array, object
* @return string
*/
function ol(array $list, string $attributes = ''): string
function ol(array $list, $attributes = ''): string
{
return _list('ol', $list, $attributes);
}
Expand All @@ -91,11 +91,11 @@ function ol(array $list, string $attributes = ''): string
*
* @param string $type
* @param mixed $list
* @param string $attributes
* @param mixed $attributes string, array, object
* @param integer $depth
* @return string
*/
function _list(string $type = 'ul', $list = [], string $attributes = '', int $depth = 0): string
function _list(string $type = 'ul', $list = [], $attributes = '', int $depth = 0): string
{
// Set the indentation based on the depth
$out = str_repeat(' ', $depth)
Expand Down