Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML Helper - Fix attribute type for lists #2516

Merged

Conversation

najdanovicivan
Copy link
Contributor

Description
This is correct way to fix #2473. There was already a PR #2488 but it's not proper solution as it does not cover all possible type

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@lonnieezell lonnieezell merged commit 2a69569 into codeigniter4:develop Jan 27, 2020
@najdanovicivan najdanovicivan deleted the html-helper-lists-fix branch February 14, 2020 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Unable to use ul() helper with out modification
2 participants