Fix: Use of CodeIgniter\Config\Services prevents Service overriding #2381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See #2376 The following statement is used by multiple "core" classes `use CodeIgniter\Config\Services;` This results in `App\Config\Services` being bypassed. All namespace use statements for `Services` in the core classes changed to ` use Config\Services;` so the overrides can be accomplished.
|
I think this is good. I also think we need to define a) what can and can't be extended/overridden, and b) what order of precedence various sections give to App/System/Modules/etc. See also #2355 (comment) |
|
Yes, those were from around from before some of the extension concepts were solidified. So, yes, perfect. Everything should always extend Config\Services. Thanks. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2376
The following statement is used by multiple "core" classes
This results in
App\Config\Servicesbeing bypassed which preventsServiceoverrides from being recognized.All namespace use statements for
Servicesin the core classes changed touse Config\Services;so the overrides can be accomplished.Note: There are a lot of test files that explicitly use
CodeIgniter\Config\Servicesthat were not changed in the PR. They probably don't need to be and/or should not be changed, but I wanted to point that out.