-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replaced language setting in APPPATH."Language" #2355
Conversation
I like the idea but this is causing |
Some problems with this PR:
|
@MGatner @lonnieezell Neither the user guide or code suggest anything about prioritizing one namespace over another, which appears to be the goal of the bug report / PR. Should App be prioritized? |
I think file locating needs to have an explicit hierarchy, which might vary depending on the component.
As a regular module writer, I do think it is important for developers to be able to supply their own phrasing without modifying the module - so in this case I'm in favor of prioritizing |
So, classes etc order would be System, Config, App, Modules, but message collapsing should be System, Config, Modules, App? |
I do think what this is addressing constitutes an issue, but I don't think this is the solution.
Any language files in Additionally, this is causing tests to fail and the commit is not signed. Closing the PR, but I will open a corresponding issue so it doesn't get lost. |
Just had a look at the open issues, and no corresponding issue found. Just a reminder to prevent this issue being unresolved. |
The issue is linked directly above yours and has already been addressed. If you’re having a similar issue you could open a support thread on the forums. |
Fix issue #2354
Description
Updated
CodeIgniter\Language\Language::requireFile()
to prefer APPPATH."Language" DirectoryChecklist: