New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use DBGroup variable from migration class if defined #2303

Merged

lonnieezell merged 2 commits into codeigniter4:develop from michalsn:migration_groups

Oct 8, 2019

Member

michalsn commented Oct 5, 2019

Description
This PR fixes issue #2087, as described by @lonnieezell, how this should work:

A migration that has a group specified will always use that group when doing it's migrations
If no group is specified it uses the default group
If a group is specified on the cli, then it acts like a filter and only migrations that use that db group are ran. Only applies to up since rollbacks simply rollback the last set of migrations that were ran, no matter how they were filtered.

Checklist:

michalsn added 2 commits

October 5, 2019 18:20


          Use DBGroup from migration class if defined

84665be


          [ci skip] comment update

4908d43

lonnieezell merged commit 5295d37 into codeigniter4:develop

michalsn deleted the migration_groups branch

March 5, 2020 14:31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet