Merge pull request #2303 from michalsn/migration_groups

Use DBGroup variable from migration class if defined
codeigniter4 · Oct 8, 2019 · 5295d37 · 5295d37
2 parents 10755eb + 4908d43
commit 5295d37
Show file tree

Hide file tree

Showing 2 changed files with 40 additions and 5 deletions.
diff --git a/system/Database/Migration.php b/system/Database/Migration.php
@@ -74,7 +74,7 @@ abstract class Migration
 	 */
 	public function __construct(Forge $forge = null)
 	{
-		$this->forge = ! is_null($forge) ? $forge : \Config\Database::forge($this->DBGroup);
+		$this->forge = ! is_null($forge) ? $forge : \Config\Database::forge($this->DBGroup ?? config('Database')->defaultGroup);
 
 		$this->db = $this->forge->getConnection();
 	}
@@ -86,7 +86,7 @@ public function __construct(Forge $forge = null)
 	 *
 	 * @return string
 	 */
-	public function getDBGroup(): string
+	public function getDBGroup(): ?string
 	{
 		return $this->DBGroup;
 	}

diff --git a/system/Database/MigrationRunner.php b/system/Database/MigrationRunner.php
@@ -128,6 +128,20 @@ class MigrationRunner
 	 */
 	protected $path;
 
+	/**
+	 * The database Group filter.
+	 *
+	 * @var string
+	 */
+	protected $groupFilter;
+
+	/**
+	 * Used to skip current migration.
+	 *
+	 * @var boolean
+	 */
+	protected $groupSkip = false;
+
 	//--------------------------------------------------------------------
 
 	/**
@@ -180,6 +194,7 @@ public function latest(string $group = null)
 		// Set database group if not null
 		if (! is_null($group))
 		{
+			$this->groupFilter = $group;
 			$this->setGroup($group);
 		}
 
@@ -206,6 +221,12 @@ public function latest(string $group = null)
 		{
 			if ($this->migrate('up', $migration))
 			{
+				if ($this->groupSkip === true)
+				{
+					$this->groupSkip = false;
+					continue;
+				}
+
 				$this->addHistory($migration, $batch);
 			}
 			// If a migration failed then try to back out what was done
@@ -370,6 +391,7 @@ public function force(string $path, string $namespace, string $group = null)
 		// Set database group if not null
 		if (! is_null($group))
 		{
+			$this->groupFilter = $group;
 			$this->setGroup($group);
 		}
 
@@ -406,11 +428,13 @@ public function force(string $path, string $namespace, string $group = null)
 			// Start a new batch
 			$batch = $this->getLastBatch() + 1;
 
-			if ($this->migrate('up', $migration))
+			if ($this->migrate('up', $migration) && $this->groupSkip === false)
 			{
 				$this->addHistory($migration, $batch);
 				return true;
 			}
+
+			$this->groupSkip = false;
 		}
 
 		// down
@@ -991,8 +1015,19 @@ protected function migrate($direction, $migration): bool
 			throw new \RuntimeException($message);
 		}
 
-		// Forcing migration to selected database group
-		$instance = new $class(\Config\Database::forge($this->group));
+		// Initialize migration
+		$instance = new $class();
+		// Determine DBGroup to use
+		$group = $instance->getDBGroup() ?? config('Database')->defaultGroup;
+
+		// Skip migration if group filtering was set
+		if ($direction === 'up' && ! is_null($this->groupFilter) && $this->groupFilter !== $group)
+		{
+			$this->groupSkip = true;
+			return true;
+		}
+
+		$this->setGroup($group);
 
 		if (! is_callable([$instance, $direction]))
 		{