-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes #2049 - debug option #2204
Conversation
NOTE: These should fail until codeigniter4#2049 is resolved.
I think @xbotkaj was right and Also can you merge my tests from #2168? Let me know if you want help with a cross-user-fork merge. |
Yes, I removed the Crap... seems like merge portion wasn't signed 😞 oh well... |
This is looking good. If there is any way you can setup signing on the device you did the merge from then GitHub will verify it retroactively. Unless @lonnieezell wants to override the merge block. |
… feature/curl_debug_fix sign merge
2d7ebd9
to
c407a15
Compare
Well... I made this (not signed) merge on the same device. I tried to fix it somehow yesterday but from what I can see I failed. So, idk... if you can't merge this just close this pull request, copy my code (it's just 3 lines actually) and add it to your branch with tests @MGatner - I don't mind. |
:D thanks! I can probably merge your commits and keep you as the author and just do a verified merge myself. I’ll take a look later tonight - we already got another CURL debug report so I’m eager to get this in. |
Ok, thanks @MGatner. |
Description
CURLRequest class with the default
debug
value reports an error:This pull request fixes this issue and ensures to create resource if we specify a path to the log file. I believe that tests for this are already started in #2168.
Checklist: