Update CURLRequest.php

[nowackipawel]

aa362d0

prvious fix caused eception if debug has not been specified
Type: ErrorException
Message: curl_setopt_array(): supplied argument is not a valid File-Handle resource
Filename: /home/-exchange/site/system/HTTP/CURLRequest.php

[nowackipawel]

@lonnieezell : I think test "testDebugOption" is written wrongly. "

CURLOPT_STDERR | An alternative location to output errors to instead of STDERR.

IMHO CURLOPT_STDERR should be set to file handle or should not exists.

[nowackipawel]

@lonnieezell could you answer pls? Am I wrong or not my approach is correct?

[lonnieezell]

I'm confused. When is $config['debug'] going to be a resource? According to the docs it should only ever be a boolean. If true, it turns on verbose and sets the error output, otherwise it leaves verbose to whatever it was otherwise set at.

[lonnieezell]

While it may crash if debug hasn't been specified, what you're changing it to doesn't work. See my comment for explanation.

[nowackipawel]

According to docs CURLOPT_STDERR should be a resource or should not be specified. This line in old code: ``` $curl_options[CURLOPT_STDERR] = $config['debug'] === true ? fopen('php://output', 'w+') : $config['debug']; ``` caused an exception if someone tried to (if I remember correctly) set false there.

…

--- CURLOPT_STDERR | An alternative location to output errors to instead of STDERR. -- | -- Contrary to the documentation, CURLOPT_STDERR should be set to a handle to the file you want to write to, not the file's location.

[MGatner]

I'm encountering this on a fresh install. Even without doing any configuration:

$client = Services::curlrequest();
$response = $client->request('GET', 'https://example.com');

I get an exception:

An uncaught Exception was encountered

Type:        ErrorException
Message:     curl_setopt_array(): supplied argument is not a valid File-Handle resource
Filename:    .../vendor/codeigniter4/codeigniter4/system/HTTP/CURLRequest.php
Line Number: 808

I'll dig into it a bit.

[MGatner]

Okay a couple issues going on here.

---

First issue, the class starts with some default values for $config:

protected $config = [
	'timeout'         => 0.0,
	'connect_timeout' => 150,
	'debug'           => false,
	'verify'          => true,
];

This means that in setCURLOptions() the following will always be true:

	if (isset($config['debug']))
	{
		$curl_options[CURLOPT_VERBOSE] = $config['debug'] === true ? 1 : 0;
		$curl_options[CURLOPT_STDERR]  = $config['debug'] === true ? fopen('php://output', 'w+') : $config['debug'];
	}

Because of this if no overriding value was passed for debug then $curl_options[CURLOPT_STDERR] will end up being boolean false, which causes the error in my last comment. The easy fix for this issue is just if ($config['debug']).

---

Second issue, if $curl_options[CURLOPT_STDERR] is set it has to be a stream resource (not bool, not path). From PHP.net:

value should be a stream resource (using fopen(), for example) for the following values of the option parameter:
...
CURLOPT_STDERR An alternative location to output errors to instead of STDERR

Consulting the CI4 User Manual on CURLRequest:

You can pass a filename as the value for debug to have the output written to a file:
$response->request('GET', 'http://example.com', ['debug' => '/usr/local/curl_log.txt']);

So @lonnieezell we need to decide if we still want to pass in file paths, and if so we need to make a resource from them, so then need to decide if we're going to check the path or just let that be an exception from somewhere else (File class maybe?).

---

I can make a new PR but this needs a little scrutiny first.

[lonnieezell]

@MGatner yes, you're right. My apologies to @nowackipawel

We should allow a file name to be specified - so convert it to a resource behind the scenes I guess. I don't think it needs to check the path. If it doesn't exist it should create it. If it does exist, and is writable, then it would get overwritten. If it can't be written to (or outside safe_mode boundaries) then it should naturally throw an exception. I would think that exception would be clear enough about what happened and why.