Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix file locator slash error #2064

Merged
merged 2 commits into from
Jun 21, 2019
Merged

Bugfix file locator slash error #2064

merged 2 commits into from
Jun 21, 2019

Conversation

MGatner
Copy link
Member

@MGatner MGatner commented Jun 20, 2019 •
edited
Loading

Description
#2059 introduced a scenario where the combination of $path and $folder could fail to have a separating slash. This PR moves the trailing slash safety check prior to the folder test.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@MGatner
Copy link
Member Author

MGatner commented Jun 21, 2019

Okay I think this is all set now. So many slash woes!

@lonnieezell lonnieezell merged commit 78b55f8 into codeigniter4:develop Jun 21, 2019
@MGatner MGatner deleted the bugfix-locator branch June 21, 2019 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lonnieezell lonnieezell lonnieezell left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MGatner @lonnieezell