Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi-path support to locateFile() #2059

Merged
merged 2 commits into from
Jun 20, 2019

Conversation

MGatner
Copy link
Member

@MGatner MGatner commented Jun 17, 2019

Description
Currently locateFile() flattens namespace paths to a single path per namespace (see #1866). This fix searches all namespace paths for the first matching file.

This change also removes the auto-capitalize of namespaces as this is not a namespace requirement and could cause locateFile to fail to match valid file namespaces.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@lonnieezell lonnieezell merged commit 624db39 into codeigniter4:develop Jun 20, 2019
@MGatner MGatner deleted the update-getnamespaces branch June 20, 2019 10:48
@MGatner MGatner mentioned this pull request Jun 20, 2019
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants