Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Don't Escape feature for db engine #1677

Merged
merged 3 commits into from
Jan 23, 2019
Merged

Conversation

lonnieezell
Copy link
Member

Add in missing don't escape feature that seemed to be missing since the original DB refactor.

Fixes #1667

@lonnieezell lonnieezell merged commit df38172 into develop Jan 23, 2019
@lonnieezell lonnieezell deleted the escapeinserts branch January 24, 2019 05:10
@vlakoff
Copy link
Contributor

vlakoff commented Oct 11, 2021

On a related note, I don't really understand the comment here:

While it might be nicer to have named keys for our binds array
with PHP 7+ we get a huge memory/performance gain with indexed
arrays instead, so lets take advantage of that here.

... as these array keys are still named keys (e.g. "foobar", "foobar.2", "foobar.3", etc)

We could easily switch to numeric keys. But would it cause BC issues?


Refs: PHP 7 performance improvements (1/5): Packed arrays

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

insertBatch with escape=false still escapes values
2 participants