Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

insertBatch with escape=false still escapes values #1667

Closed
niteraven7 opened this issue Jan 17, 2019 · 2 comments · Fixed by #1677
Closed

insertBatch with escape=false still escapes values #1667

niteraven7 opened this issue Jan 17, 2019 · 2 comments · Fixed by #1677
Labels
database Issues or pull requests that affect the database layer

Comments

@niteraven7
Copy link

I'm supposed to be able to choose to not escape values so I can insert functions like NOW() instead of 'NOW()'. It appears to NOT be working and escapes values anyhow.

https://codeigniter4.github.io/CodeIgniter4/database/query_builder.html#CodeIgniterDatabaseBaseBuilder::insertBatch

Here's the old discussion thread and fix for version 3:

bcit-ci/CodeIgniter#1895

using: alpha4

@lonnieezell lonnieezell added the database Issues or pull requests that affect the database layer label Jan 21, 2019
@lonnieezell
Copy link
Member

@niteraven7 thanks for reporting this! It looks like my original database refactor from the CI3 code failed to actually implement the "do not escape" feature! Doh! How embarrassing. Fixed in #1677.

@niteraven7
Copy link
Author

niteraven7 commented Jan 21, 2019

Thank you @lonnieezell ! Your dedication and tireless work is greatly appreciated. CI4 is getting more awesome and solid by the day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
database Issues or pull requests that affect the database layer
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants