Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

autoload clean up: remove Psr\Log namespace from composer.json #1555

Merged
merged 4 commits into from
Dec 3, 2018
Merged

autoload clean up: remove Psr\Log namespace from composer.json #1555

merged 4 commits into from
Dec 3, 2018

Conversation

samsonasik
Copy link
Member

To be used system/Config/AutoloadConfig.php file for its definition.

Checklist:

  • Securely signed commits

@samsonasik
Copy link
Member Author

samsonasik commented Nov 30, 2018 •
edited
Loading

travis somehow doesn't read AutoloadConfig::classmap, I added "psr/log": "^1.1" to composer.json, so it consistent with addition of other third parties deps (kint and zend-escaper)

@samsonasik samsonasik force-pushed the composer-clean-up-psr branch from d337365 to d152156 Compare November 30, 2018 15:29
@samsonasik samsonasik force-pushed the composer-clean-up-psr branch from d152156 to 8659cbf Compare December 1, 2018 01:40
@samsonasik
Copy link
Member Author

updated composer.json at admin/framework/composer.json as well.

@lonnieezell lonnieezell merged commit 48e3795 into codeigniter4:develop Dec 3, 2018
@samsonasik samsonasik deleted the composer-clean-up-psr branch December 3, 2018 11:58
@samsonasik samsonasik mentioned this pull request Dec 10, 2018
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samsonasik @lonnieezell