Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

admin/starter/composer.json clean up #1600

Merged
merged 1 commit into from
Dec 12, 2018

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik commented Dec 10, 2018

Since "codeigniter4/framework": "^4@alpha" already in require part, the other libs that already in codeigniter4/framework should no longer needed to be registered in composer.json.

Checklist:

  • Securely signed commits

@samsonasik samsonasik changed the title starter/composer.json clean up admin/starter/composer.json clean up Dec 10, 2018
Copy link
Contributor

@jim-parry jim-parry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to test this first - I have come across conflicting docs re pulling in subdependencies & the autoloader config. If this does work properly, I am all for simplification :)
I am on campus (exams!), but will check this out this evening (my time)!

@jim-parry
Copy link
Contributor

Checks out :)
Sorry for the delay testing - crazy time of year!

@jim-parry jim-parry merged commit 5d09c16 into codeigniter4:develop Dec 12, 2018
@samsonasik samsonasik deleted the autoload-rem-starter branch December 12, 2018 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants