Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Move from commit SHA to 22 char hash and polyfill Promise.allSettled #3410

Merged
merged 2 commits into from
Oct 18, 2024
Merged

fix: Move from commit SHA to 22 char hash and polyfill Promise.allSettled #3410

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d3f7840
bump codecov plugin version
nicholas-codecov Oct 18, 2024
bdbf33e
update vite config with different output file names and polyfill Prom…
nicholas-codecov Oct 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@
"@acemarke/react-prod-sourcemaps": "^0.3.1",
"@babel/plugin-proposal-private-property-in-object": "^7.21.11",
"@chromatic-com/storybook": "^1",
"@codecov/vite-plugin": "^1.0.1",
"@codecov/vite-plugin": "^1.2.1",
"@sentry/vite-plugin": "^2.22.4",
"@storybook/addon-a11y": "^8.3.4",
"@storybook/addon-actions": "^8.3.4",
Expand Down
17 changes: 8 additions & 9 deletions vite.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,14 +56,6 @@ export default defineConfig((config) => {
)
}

// conditionally add the commit sha to the asset and chunk file names
let assetFileNames
let chunkFileNames
if (process.env.GAZEBO_SHA) {
assetFileNames = `assets/[name]-${process.env.GAZEBO_SHA}-[hash][extname]`
chunkFileNames = `assets/[name]-${process.env.GAZEBO_SHA}-[hash].js`
}

return {
server: {
port: 3000,
Expand All @@ -72,7 +64,11 @@ export default defineConfig((config) => {
outDir: 'build',
sourcemap: runSentryPlugin,
rollupOptions: {
output: { assetFileNames, chunkFileNames },
output: {
entryFileNames: 'assets/[name].[hash:22].js',
chunkFileNames: 'assets/[name].[hash:22].js',
assetFileNames: 'assets/[name].[hash:22][extname]',
},
},
},
define: envWithProcessPrefix,
Expand All @@ -83,7 +79,10 @@ export default defineConfig((config) => {
}),
tsconfigPaths(),
legacy({
// which legacy browsers to support
targets: ['>0.2%', 'not dead', 'not op_mini all'],
// which polyfills to include in the modern build
modernPolyfills: ['es.promise.all-settled'],
}),
react(),
svgr(),
Expand Down
20 changes: 10 additions & 10 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3358,29 +3358,29 @@ __metadata:
languageName: node
linkType: hard

"@codecov/bundler-plugin-core@npm:^1.0.1":
version: 1.0.1
resolution: "@codecov/bundler-plugin-core@npm:1.0.1"
"@codecov/bundler-plugin-core@npm:^1.2.1":
version: 1.2.1
resolution: "@codecov/bundler-plugin-core@npm:1.2.1"
dependencies:
"@actions/core": "npm:^1.10.1"
"@actions/github": "npm:^6.0.0"
chalk: "npm:4.1.2"
semver: "npm:^7.5.4"
unplugin: "npm:^1.10.1"
zod: "npm:^3.22.4"
checksum: 10c0/4a2fbcb0d33ada3c5f0335fae555cc534b46ee8e9ae4f72976b894d1d0c21954ba6309c8ee4b4d759a203674557360932c94c40f766368dfaf5195d77fe6feb8
checksum: 10c0/ec051dbfea8003b17676d0a0b24c006cfccaa9eb2a790357a5d504d214025d2b3209445d0c5889b56c4729259da4fd0845069ba6e08cd1e271706dd3da1788c6
languageName: node
linkType: hard

"@codecov/vite-plugin@npm:^1.0.1":
version: 1.0.1
resolution: "@codecov/vite-plugin@npm:1.0.1"
"@codecov/vite-plugin@npm:^1.2.1":
version: 1.2.1
resolution: "@codecov/vite-plugin@npm:1.2.1"
dependencies:
"@codecov/bundler-plugin-core": "npm:^1.0.1"
"@codecov/bundler-plugin-core": "npm:^1.2.1"
unplugin: "npm:^1.10.1"
peerDependencies:
vite: 4.x || 5.x
checksum: 10c0/e6fb5d924fd17cd4ac429c5c5279cc3ff13c25853826aa0cd70468916475d09a163df2669f3a646d7738a4659203de7ccf397ec9834813eef5e013cf4db9c72a
checksum: 10c0/bc443322859b3675456af1de2399dc380751ed1910adff0ad3dc84d625dac41fd6301192342a9fb65f033ce56bccd5ab082bb22443cc73bfd464bcf48ef5de32
languageName: node
linkType: hard

Expand Down Expand Up @@ -12550,7 +12550,7 @@ __metadata:
"@acemarke/react-prod-sourcemaps": "npm:^0.3.1"
"@babel/plugin-proposal-private-property-in-object": "npm:^7.21.11"
"@chromatic-com/storybook": "npm:^1"
"@codecov/vite-plugin": "npm:^1.0.1"
"@codecov/vite-plugin": "npm:^1.2.1"
"@hookform/resolvers": "npm:^2.8.5"
"@radix-ui/react-accordion": "npm:^1.1.2"
"@radix-ui/react-checkbox": "npm:^1.1.1"
Expand Down
Loading