Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Move from commit SHA to 22 char hash and polyfill Promise.allSettled #3410

Merged

Conversation

nicholas-codecov
Copy link
Contributor

@nicholas-codecov nicholas-codecov commented Oct 18, 2024

Description

Couple of Vite config changes here and a plugin version bump. Goal of this is to resolve some issues with caching, browsers not supporting Promise.allSettled, and bumping a plugin version so it works properly with the extended hash values.

Will hopefully resolve: https://codecov.sentry.io/issues/5968807574/events/3a931390316b4d78a3de37186f8306d1/

Notable Changes

  • Polyfill Promise.allSettled
  • Update Codecov Vite plugin
  • Adjust output file names

@codecov-staging
Copy link

Bundle Report

Changes will increase total bundle size by 26.28kB (0.16%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-system-esm* 5.2MB 450 bytes (0.01%) ⬆️
gazebo-staging-system 5.19MB 25.83kB (0.5%) ⬆️

ℹ️ *Bundle size includes cached data from a previous commit

Copy link
Contributor

@ajay-sentry ajay-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@codecov-qa
Copy link

codecov-qa bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.17%. Comparing base (7618765) to head (bdbf33e).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3410   +/-   ##
=======================================
  Coverage   99.17%   99.17%           
=======================================
  Files         809      809           
  Lines       14208    14208           
  Branches     3916     3916           
=======================================
  Hits        14091    14091           
  Misses        108      108           
  Partials        9        9           
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.93% <ø> (ø)
Services 99.45% <ø> (ø)
Shared 99.80% <ø> (ø)
UI 99.06% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7618765...bdbf33e. Read the comment docs.

Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.17%. Comparing base (7618765) to head (bdbf33e).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3410   +/-   ##
=======================================
  Coverage   99.17%   99.17%           
=======================================
  Files         809      809           
  Lines       14208    14208           
  Branches     3921     3916    -5     
=======================================
  Hits        14091    14091           
  Misses        108      108           
  Partials        9        9           
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.93% <ø> (ø)
Services 99.45% <ø> (ø)
Shared 99.80% <ø> (ø)
UI 99.06% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7618765...bdbf33e. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3410   +/-   ##
=======================================
  Coverage   99.17%   99.17%           
=======================================
  Files         809      809           
  Lines       14208    14208           
  Branches     3916     3916           
=======================================
  Hits        14091    14091           
  Misses        108      108           
  Partials        9        9           
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.93% <ø> (ø)
Services 99.45% <ø> (ø)
Shared 99.80% <ø> (ø)
UI 99.06% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7618765...bdbf33e. Read the comment docs.

@codecov-releaser
Copy link
Contributor

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
bdbf33e Fri, 18 Oct 2024 18:34:33 GMT Cloud Enterprise

@nicholas-codecov nicholas-codecov added this pull request to the merge queue Oct 18, 2024
Merged via the queue into main with commit 2e30968 Oct 18, 2024
62 checks passed
@nicholas-codecov nicholas-codecov deleted the fix-move-to-using-22-char-hash-and-polyfill-all-settled branch October 18, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants