Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Small spacing issue on coverage onboarding #3386

Merged
merged 3 commits into from
Oct 11, 2024
Merged

fix: Small spacing issue on coverage onboarding #3386

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7fedf8a
use chevronDown for icon
nicholas-codecov Oct 11, 2024
7a10265
fix apostrophe in CircleCI
nicholas-codecov Oct 11, 2024
08b126a
fix spacing issue in GitHubActions coverage onboarding
nicholas-codecov Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/pages/RepoPage/CoverageOnboarding/CircleCI/CircleCI.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ function Step3() {
<Card.Content className="flex flex-col gap-4">
<p>
Once merged to your default branch, subsequent pull requests will have
Codecov checks and comments. Additionally, you’ll find your repo
Codecov checks and comments. Additionally, you&apos;ll find your repo
coverage dashboard here. If you have merged, try reloading the page.
</p>
</Card.Content>
Expand Down
6 changes: 3 additions & 3 deletions src/pages/RepoPage/CoverageOnboarding/GitHubActions/GitHubActions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,9 +283,9 @@ jobs:
<ExpandableSection className="-mt-px">
<ExpandableSection.Trigger>
<p className="font-normal">
Your final GitHub Actions workflow for a project using 
<span className="text-codecov-code">{framework}</span>
 could look something like this:
Your final GitHub Actions workflow for a project using{' '}
<span className="text-codecov-code">{framework}</span> could look
something like this:
</p>
</ExpandableSection.Trigger>
<ExpandableSection.Content>
Expand Down
2 changes: 1 addition & 1 deletion src/ui/ExpandableSection/ExpandableSection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ const ExpandableSectionTrigger = forwardRef<
>
<span>{children}</span>
<span id="expandable-icon" className="rotate-0 transition-transform">
<Icon name="chevronUp" size="sm" />
<Icon name="chevronDown" size="sm" />
</span>
</Collapsible.Trigger>
)
Expand Down
Loading