Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Small spacing issue on coverage onboarding #3386

Merged
merged 3 commits into from
Oct 11, 2024

Conversation

nicholas-codecov
Copy link
Contributor

Description

Small fix with some spacing issues, fixing an apostrophe, and rotating the default chevron for the expandable section to be down not up (requested by @aj-codecov)

Screenshots

Before:

Screenshot 2024-10-11 at 13 22 35

After:

Screenshot 2024-10-11 at 13 19 02

@codecov-staging
Copy link

Bundle Report

Changes will decrease total bundle size by 8 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-array-push 6.14MB 8 bytes (-0.0%) ⬇️

@codecov-qa
Copy link

codecov-qa bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.18%. Comparing base (d88816e) to head (08b126a).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3386   +/-   ##
=======================================
  Coverage   99.18%   99.18%           
=======================================
  Files         803      803           
  Lines       14210    14210           
  Branches     3916     3916           
=======================================
  Hits        14094    14094           
  Misses        107      107           
  Partials        9        9           
Files with missing lines Coverage Δ
.../RepoPage/CoverageOnboarding/CircleCI/CircleCI.tsx 100.00% <ø> (ø)
...CoverageOnboarding/GitHubActions/GitHubActions.tsx 100.00% <ø> (ø)
src/ui/ExpandableSection/ExpandableSection.tsx 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.94% <ø> (ø)
Services 99.45% <ø> (ø)
Shared 99.80% <ø> (ø)
UI 99.10% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d88816e...08b126a. Read the comment docs.

Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.18%. Comparing base (d88816e) to head (08b126a).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3386   +/-   ##
=======================================
  Coverage   99.18%   99.18%           
=======================================
  Files         803      803           
  Lines       14210    14210           
  Branches     3916     3921    +5     
=======================================
  Hits        14094    14094           
  Misses        107      107           
  Partials        9        9           
Files Coverage Δ
.../RepoPage/CoverageOnboarding/CircleCI/CircleCI.tsx 100.00% <ø> (ø)
...CoverageOnboarding/GitHubActions/GitHubActions.tsx 100.00% <ø> (ø)
src/ui/ExpandableSection/ExpandableSection.tsx 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.94% <ø> (ø)
Services 99.45% <ø> (ø)
Shared 99.80% <ø> (ø)
UI 99.10% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d88816e...08b126a. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3386   +/-   ##
=======================================
  Coverage   99.18%   99.18%           
=======================================
  Files         803      803           
  Lines       14210    14210           
  Branches     3921     3916    -5     
=======================================
  Hits        14094    14094           
  Misses        107      107           
  Partials        9        9           
Files with missing lines Coverage Δ
.../RepoPage/CoverageOnboarding/CircleCI/CircleCI.tsx 100.00% <ø> (ø)
...CoverageOnboarding/GitHubActions/GitHubActions.tsx 100.00% <ø> (ø)
src/ui/ExpandableSection/ExpandableSection.tsx 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.94% <ø> (ø)
Services 99.45% <ø> (ø)
Shared 99.80% <ø> (ø)
UI 99.10% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d88816e...08b126a. Read the comment docs.

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.18%. Comparing base (d88816e) to head (08b126a).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3386   +/-   ##
=======================================
  Coverage   99.18%   99.18%           
=======================================
  Files         803      803           
  Lines       14210    14210           
  Branches     3921     3921           
=======================================
  Hits        14094    14094           
  Misses        107      107           
  Partials        9        9           
Files with missing lines Coverage Δ
.../RepoPage/CoverageOnboarding/CircleCI/CircleCI.tsx 100.00% <ø> (ø)
...CoverageOnboarding/GitHubActions/GitHubActions.tsx 100.00% <ø> (ø)
src/ui/ExpandableSection/ExpandableSection.tsx 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.94% <ø> (ø)
Services 99.45% <ø> (ø)
Shared 99.80% <ø> (ø)
UI 99.10% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d88816e...08b126a. Read the comment docs.

Copy link

codecov bot commented Oct 11, 2024

Bundle Report

Changes will decrease total bundle size by 8 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-array-push 6.14MB 8 bytes (-0.0%) ⬇️

@codecov-releaser
Copy link
Contributor

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
08b126a Fri, 11 Oct 2024 16:34:35 GMT Cloud Enterprise

@nicholas-codecov nicholas-codecov added this pull request to the merge queue Oct 11, 2024
Merged via the queue into main with commit e6a5a12 Oct 11, 2024
62 checks passed
@nicholas-codecov nicholas-codecov deleted the fix-small-spacing-issue-on-coverage-onboarding branch October 11, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants