Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Line coverage off by one in VirtualFileRenderer #3143

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

spalmurray-codecov
Copy link
Contributor

Fixes line coverage being off by one in the new VirtualFileRenderer.

@spalmurray-codecov spalmurray-codecov marked this pull request as ready for review August 21, 2024 18:53
@codecov-staging
Copy link

codecov-staging bot commented Aug 21, 2024

Bundle Report

Changes will decrease total bundle size by 12 bytes ⬇️

Bundle name Size Change
gazebo-staging-array-push 5.78MB 12 bytes ⬇️

@codecov-qa
Copy link

codecov-qa bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.30%. Comparing base (845a181) to head (78fc770).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3143   +/-   ##
=======================================
  Coverage   98.30%   98.30%           
=======================================
  Files         919      919           
  Lines       14191    14191           
  Branches     3924     3843   -81     
=======================================
  Hits        13950    13950           
  Misses        236      236           
  Partials        5        5           
Files Coverage Δ
src/ui/VirtualFileRenderer/VirtualFileRenderer.tsx 99.12% <100.00%> (ø)
Components Coverage Δ
Assets 54.05% <ø> (ø)
Layouts 98.80% <ø> (ø)
Pages 99.03% <ø> (ø)
Services 99.51% <ø> (ø)
Shared 99.71% <ø> (ø)
UI 94.51% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 845a181...78fc770. Read the comment docs.

Copy link

codecov-public-qa bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.30%. Comparing base (845a181) to head (78fc770).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3143   +/-   ##
=======================================
  Coverage   98.30%   98.30%           
=======================================
  Files         919      919           
  Lines       14191    14191           
  Branches     3898     3924   +26     
=======================================
  Hits        13950    13950           
  Misses        236      236           
  Partials        5        5           
Files Coverage Δ
src/ui/VirtualFileRenderer/VirtualFileRenderer.tsx 99.12% <100.00%> (ø)
Components Coverage Δ
Assets 54.05% <ø> (ø)
Layouts 98.80% <ø> (ø)
Pages 99.03% <ø> (ø)
Services 99.51% <ø> (ø)
Shared 99.71% <ø> (ø)
UI 94.51% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 845a181...78fc770. Read the comment docs.

Copy link

codecov bot commented Aug 21, 2024

Bundle Report

Changes will decrease total bundle size by 12 bytes ⬇️

Bundle name Size Change
gazebo-production-array-push 5.78MB 12 bytes ⬇️

@codecov-notifications
Copy link

codecov-notifications bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3143   +/-   ##
=======================================
  Coverage   98.30%   98.30%           
=======================================
  Files         919      919           
  Lines       14191    14191           
  Branches     3843     3924   +81     
=======================================
  Hits        13950    13950           
  Misses        236      236           
  Partials        5        5           
Files Coverage Δ
src/ui/VirtualFileRenderer/VirtualFileRenderer.tsx 99.12% <100.00%> (ø)
Components Coverage Δ
Assets 54.05% <ø> (ø)
Layouts 98.80% <ø> (ø)
Pages 99.03% <ø> (ø)
Services 99.51% <ø> (ø)
Shared 99.71% <ø> (ø)
UI 94.51% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 845a181...78fc770. Read the comment docs.

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Aug 21, 2024

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
aaa9172 Wed, 21 Aug 2024 18:58:40 GMT Expired Expired
78fc770 Wed, 21 Aug 2024 19:21:59 GMT Cloud Enterprise

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.30%. Comparing base (845a181) to head (78fc770).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##               main      #3143   +/-   ##
===========================================
  Coverage   98.30000   98.30000           
===========================================
  Files           919        919           
  Lines         14191      14191           
  Branches       3843       3843           
===========================================
  Hits          13950      13950           
  Misses          236        236           
  Partials          5          5           
Files Coverage Δ
src/ui/VirtualFileRenderer/VirtualFileRenderer.tsx 99.12% <100.00%> (ø)
Components Coverage Δ
Assets 54.05% <ø> (ø)
Layouts 98.80% <ø> (ø)
Pages 99.03% <ø> (ø)
Services 99.51% <ø> (ø)
Shared 99.71% <ø> (ø)
UI 94.51% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 845a181...78fc770. Read the comment docs.

Copy link
Contributor

@ajay-sentry ajay-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dank!

@spalmurray-codecov spalmurray-codecov added this pull request to the merge queue Aug 21, 2024
Merged via the queue into main with commit 3ed348a Aug 21, 2024
61 checks passed
@spalmurray-codecov spalmurray-codecov deleted the spalmurray/fix-vfr-off-by-one branch August 21, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants