-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Line coverage off by one in VirtualFileRenderer #3143
Conversation
Bundle ReportChanges will decrease total bundle size by 12 bytes ⬇️
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3143 +/- ##
=======================================
Coverage 98.30% 98.30%
=======================================
Files 919 919
Lines 14191 14191
Branches 3924 3843 -81
=======================================
Hits 13950 13950
Misses 236 236
Partials 5 5
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3143 +/- ##
=======================================
Coverage 98.30% 98.30%
=======================================
Files 919 919
Lines 14191 14191
Branches 3898 3924 +26
=======================================
Hits 13950 13950
Misses 236 236
Partials 5 5
Continue to review full report in Codecov by Sentry.
|
Bundle ReportChanges will decrease total bundle size by 12 bytes ⬇️
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3143 +/- ##
=======================================
Coverage 98.30% 98.30%
=======================================
Files 919 919
Lines 14191 14191
Branches 3843 3924 +81
=======================================
Hits 13950 13950
Misses 236 236
Partials 5 5
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3143 +/- ##
===========================================
Coverage 98.30000 98.30000
===========================================
Files 919 919
Lines 14191 14191
Branches 3843 3843
===========================================
Hits 13950 13950
Misses 236 236
Partials 5 5
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dank!
Fixes line coverage being off by one in the new VirtualFileRenderer.