fix: Line coverage off by one in VirtualFileRenderer (#3143)

codecov · Aug 21, 2024 · 3ed348a · 3ed348a
1 parent 845a181
commit 3ed348a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/ui/VirtualFileRenderer/VirtualFileRenderer.spec.tsx b/src/ui/VirtualFileRenderer/VirtualFileRenderer.spec.tsx
@@ -69,9 +69,9 @@ const code = `<Breadcrumb
 />`
 
 const coverageData = {
-  0: 'H',
-  1: 'M',
-  2: 'P',
+  1: 'H',
+  2: 'M',
+  3: 'P',
 } as unknown as Dictionary<'H' | 'M' | 'P'>
 
 let testLocation: ReturnType<typeof useLocation>

diff --git a/src/ui/VirtualFileRenderer/VirtualFileRenderer.tsx b/src/ui/VirtualFileRenderer/VirtualFileRenderer.tsx
@@ -153,7 +153,7 @@ const CodeBody = ({
       <div className="relative z-[2] h-full w-[86px] min-w-[86px] pr-[10px]">
         {virtualizer.getVirtualItems().map((item) => {
           const lineNumber = item.index + 1
-          const coverageValue = coverage?.[item.index]
+          const coverageValue = coverage?.[lineNumber]
 
           return (
             <div
@@ -243,7 +243,7 @@ const CodeBody = ({
               <ColorBar
                 lineNumber={lineNumber}
                 locationHash={location.hash}
-                coverage={coverage?.[item.index]}
+                coverage={coverage?.[lineNumber]}
               />
               <div
                 className="w-full"
-Original file line number
+Diff line change
@@ Expand Up / @@ -69,9 +69,9 @@ const code = `<Breadcrumb @@
     />`
     const coverageData = {
-: 'H',
-: 'M',
-: 'P',
+: 'H',
+: 'M',
+: 'P',
     } as unknown as Dictionary<'H' | 'M' | 'P'>
     let testLocation: ReturnType<typeof useLocation>
@@ Expand Down @@