Remove the "Subscription Update Failed" banner when there is no error #3064
Conversation
Bundle ReportChanges will decrease total bundle size by 366 bytes ⬇️
|
Bundle ReportChanges will decrease total bundle size by 366 bytes ⬇️
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3064 +/- ##
==========================================
- Coverage 98.04% 98.04% -0.01%
==========================================
Files 925 925
Lines 13772 13770 -2
Branches 3737 3741 +4
==========================================
- Hits 13503 13501 -2
Misses 265 265
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3064 +/- ##
==========================================
- Coverage 98.04% 98.04% -0.01%
==========================================
Files 925 925
Lines 13772 13770 -2
Branches 3742 3736 -6
==========================================
- Hits 13503 13501 -2
Misses 265 265
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3064 +/- ##
==========================================
- Coverage 98.04% 98.04% -0.01%
==========================================
Files 925 925
Lines 13772 13770 -2
Branches 3662 3736 +74
==========================================
- Hits 13503 13501 -2
Misses 265 265
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3064 +/- ##
===========================================
Coverage 98.04000 98.04000
===========================================
Files 925 925
Lines 13772 13770 -2
Branches 3737 3712 -25
===========================================
- Hits 13503 13501 -2
Misses 265 265
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Description
This closes codecov/engineering-team#1795.
The error banner will no longer render when the user navigates back from the stripe checkout session. We have a
DelinquentAlertin the parent component that handles any relevant messaging.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.