Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the "Subscription Update Failed" banner when there has no actual error #1795

Closed
Tracked by #2057
Adal3n3 opened this issue May 21, 2024 · 2 comments · Fixed by codecov/gazebo#3064
Closed
Tracked by #2057
Assignees
Labels
bug Something isn't working Polish polish, tweaks, and bug issues that are small iterations and/or not part of larger quarterly epics

Comments

@Adal3n3
Copy link

Adal3n3 commented May 21, 2024

Problem to solve

Description

If a customer goes to Stripe checkout page and then click on return, we trigger this error banner and tell them update failed which is misleading because nothing has failed.
Screenshot 2024-05-21 at 3 30 38 PM

Solution

Remove the error banner.

@Adal3n3 Adal3n3 added the in discovery The design, product, and specifications require refinement label May 21, 2024
@Adal3n3 Adal3n3 added the Polish polish, tweaks, and bug issues that are small iterations and/or not part of larger quarterly epics label May 22, 2024
@Adal3n3 Adal3n3 removed the in discovery The design, product, and specifications require refinement label May 22, 2024
@Adal3n3 Adal3n3 changed the title Remove the "Subscription Update Failed" banner Remove the "Subscription Update Failed" banner when there has no actual error May 22, 2024
@Adal3n3
Copy link
Author

Adal3n3 commented May 22, 2024

@ajay-sentry Can we detect an actual failed payment? and indicate the failed payment in an error banner here?

@ajay-sentry ajay-sentry added the bug Something isn't working label May 23, 2024
@ajay-sentry
Copy link

@Adal3n3 We should be able to use the "delinquency" status on the owner model for now and if it exists for a user, we can show the payment banner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Polish polish, tweaks, and bug issues that are small iterations and/or not part of larger quarterly epics
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants