feat: Hide old header stuff when new header flag is true #2967

spalmurray-codecov · 2024-06-24T20:50:47Z

Hides all primary and secondary Navs along with old header whenever the newHeader feature flag is true. This is prep for implementing the new header/nav and will not affect any users until the proper rollout of the feature.

Closes codecov/engineering-team#1935
Closes codecov/engineering-team#1951

codecov-qa · 2024-06-24T20:53:48Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.35%. Comparing base (6b9f9c1) to head (2a5b927).

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #2967   +/-   ##
=======================================
  Coverage   98.35%   98.35%           
=======================================
  Files         887      889    +2     
  Lines       13159    13187   +28     
  Branches     3432     3510   +78     
=======================================
+ Hits        12942    12970   +28     
  Misses        213      213           
  Partials        4        4

Files	Coverage Δ
src/layouts/BaseLayout/BaseLayout.jsx	`96.42% <100.00%> (+0.27%)`	⬆️
src/layouts/Header/Header.tsx	`100.00% <100.00%> (ø)`
src/layouts/LoginLayout/LoginLayout.tsx	`100.00% <100.00%> (ø)`
src/pages/AccountSettings/shared/Header/Header.jsx	`100.00% <100.00%> (ø)`
...ttings/AdminSettingsHeader/AdminSettingsHeader.jsx	`100.00% <100.00%> (ø)`
src/pages/AnalyticsPage/AnalyticsPage.jsx	`100.00% <100.00%> (ø)`
src/pages/CommitDetailPage/CommitDetailPage.tsx	`100.00% <100.00%> (ø)`
src/pages/MembersPage/MembersPage.jsx	`100.00% <100.00%> (ø)`
src/pages/OwnerPage/OwnerPage.jsx	`100.00% <100.00%> (ø)`
src/pages/PlanPage/PlanPage.jsx	`100.00% <100.00%> (ø)`
... and 2 more

... and 1 file with indirect coverage changes

Components	Coverage Δ
Assets	`53.84% <ø> (ø)`
Layouts	`97.23% <100.00%> (+0.05%)`	⬆️
Pages	`99.15% <100.00%> (+<0.01%)`	⬆️
Services	`99.46% <ø> (ø)`
Shared	`99.68% <ø> (ø)`
UI	`94.58% <ø> (+<0.01%)`	⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b9f9c1...2a5b927. Read the comment docs.

codecov-public-qa · 2024-06-24T20:54:03Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.35%. Comparing base (6b9f9c1) to head (2a5b927).

✅ All tests successful. No failed tests found ☺️

@@           Coverage Diff           @@
##             main    #2967   +/-   ##
=======================================
  Coverage   98.35%   98.35%           
=======================================
  Files         887      889    +2     
  Lines       13159    13187   +28     
  Branches     3478     3510   +32     
=======================================
+ Hits        12942    12970   +28     
  Misses        213      213           
  Partials        4        4

Files	Coverage Δ
src/layouts/BaseLayout/BaseLayout.jsx	`96.42% <100.00%> (+0.27%)`	⬆️
src/layouts/Header/Header.tsx	`100.00% <100.00%> (ø)`
src/layouts/LoginLayout/LoginLayout.tsx	`100.00% <100.00%> (ø)`
src/pages/AccountSettings/shared/Header/Header.jsx	`100.00% <100.00%> (ø)`
...ttings/AdminSettingsHeader/AdminSettingsHeader.jsx	`100.00% <100.00%> (ø)`
src/pages/AnalyticsPage/AnalyticsPage.jsx	`100.00% <100.00%> (ø)`
src/pages/CommitDetailPage/CommitDetailPage.tsx	`100.00% <100.00%> (ø)`
src/pages/MembersPage/MembersPage.jsx	`100.00% <100.00%> (ø)`
src/pages/OwnerPage/OwnerPage.jsx	`100.00% <100.00%> (ø)`
src/pages/PlanPage/PlanPage.jsx	`100.00% <100.00%> (ø)`
... and 2 more

... and 1 file with indirect coverage changes

Components	Coverage Δ
Assets	`53.84% <ø> (ø)`
Layouts	`97.23% <100.00%> (+0.05%)`	⬆️
Pages	`99.15% <100.00%> (+<0.01%)`	⬆️
Services	`99.46% <ø> (ø)`
Shared	`99.68% <ø> (ø)`
UI	`94.58% <ø> (+<0.01%)`	⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b9f9c1...2a5b927. Read the comment docs.

codecov-notifications · 2024-06-24T20:54:08Z

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #2967   +/-   ##
=======================================
  Coverage   98.35%   98.35%           
=======================================
  Files         887      889    +2     
  Lines       13159    13187   +28     
  Branches     3432     3491   +59     
=======================================
+ Hits        12942    12970   +28     
  Misses        213      213           
  Partials        4        4

Files	Coverage Δ
src/layouts/BaseLayout/BaseLayout.jsx	`96.42% <100.00%> (+0.27%)`	⬆️
src/layouts/Header/Header.tsx	`100.00% <100.00%> (ø)`
src/layouts/LoginLayout/LoginLayout.tsx	`100.00% <100.00%> (ø)`
src/pages/AccountSettings/shared/Header/Header.jsx	`100.00% <100.00%> (ø)`
...ttings/AdminSettingsHeader/AdminSettingsHeader.jsx	`100.00% <100.00%> (ø)`
src/pages/AnalyticsPage/AnalyticsPage.jsx	`100.00% <100.00%> (ø)`
src/pages/CommitDetailPage/CommitDetailPage.tsx	`100.00% <100.00%> (ø)`
src/pages/MembersPage/MembersPage.jsx	`100.00% <100.00%> (ø)`
src/pages/OwnerPage/OwnerPage.jsx	`100.00% <100.00%> (ø)`
src/pages/PlanPage/PlanPage.jsx	`100.00% <100.00%> (ø)`
... and 2 more

... and 1 file with indirect coverage changes

Components	Coverage Δ
Assets	`53.84% <ø> (ø)`
Layouts	`97.23% <100.00%> (+0.05%)`	⬆️
Pages	`99.15% <100.00%> (+<0.01%)`	⬆️
Services	`99.46% <ø> (ø)`
Shared	`99.68% <ø> (ø)`
UI	`94.58% <ø> (+<0.01%)`	⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b9f9c1...2a5b927. Read the comment docs.

codecov · 2024-06-24T20:55:37Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.35%. Comparing base (6b9f9c1) to head (2a5b927).

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@             Coverage Diff             @@
##               main      #2967   +/-   ##
===========================================
  Coverage   98.35000   98.35000           
===========================================
  Files           887        889    +2     
  Lines         13159      13187   +28     
  Branches       3432       3510   +78     
===========================================
+ Hits          12942      12970   +28     
  Misses          213        213           
  Partials          4          4

Files	Coverage Δ
src/layouts/BaseLayout/BaseLayout.jsx	`96.42% <100.00%> (+0.27%)`	⬆️
src/layouts/Header/Header.tsx	`100.00% <100.00%> (ø)`
src/layouts/LoginLayout/LoginLayout.tsx	`100.00% <100.00%> (ø)`
src/pages/AccountSettings/shared/Header/Header.jsx	`100.00% <100.00%> (ø)`
...ttings/AdminSettingsHeader/AdminSettingsHeader.jsx	`100.00% <100.00%> (ø)`
src/pages/AnalyticsPage/AnalyticsPage.jsx	`100.00% <100.00%> (ø)`
src/pages/CommitDetailPage/CommitDetailPage.tsx	`100.00% <100.00%> (ø)`
src/pages/MembersPage/MembersPage.jsx	`100.00% <100.00%> (ø)`
src/pages/OwnerPage/OwnerPage.jsx	`100.00% <100.00%> (ø)`
src/pages/PlanPage/PlanPage.jsx	`100.00% <100.00%> (ø)`
... and 2 more

... and 1 file with indirect coverage changes

Components	Coverage Δ
Assets	`53.84% <ø> (ø)`
Layouts	`97.23% <100.00%> (+0.05%)`	⬆️
Pages	`99.15% <100.00%> (+<0.01%)`	⬆️
Services	`99.46% <ø> (ø)`
Shared	`99.68% <ø> (ø)`
UI	`94.58% <ø> (+<0.01%)`	⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b9f9c1...2a5b927. Read the comment docs.

codecov-staging · 2024-06-24T20:56:18Z

Bundle Report

Changes will increase total bundle size by 789 bytes ⬆️

Bundle name	Size	Change
gazebo-staging-array-push	6.74MB	789 bytes ⬆️

codecov · 2024-06-24T20:56:32Z

Bundle Report

Changes will increase total bundle size by 789 bytes ⬆️

Bundle name	Size	Change
gazebo-production-array-push	6.74MB	789 bytes ⬆️

codecov-releaser · 2024-06-24T21:01:42Z

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit	Created	Cloud	Enterprise
`8ea3e0a`	Mon, 24 Jun 2024 21:01:42 GMT	Expired	Expired
`374fb9a`	Wed, 26 Jun 2024 18:11:57 GMT	Expired	Expired
`12ae5de`	Wed, 26 Jun 2024 18:46:18 GMT	Expired	Expired
`82e7c96`	Wed, 26 Jun 2024 18:57:21 GMT	Expired	Expired
`82e7c96`	Wed, 26 Jun 2024 19:04:00 GMT	Expired	Expired
`ad48b84`	Wed, 26 Jun 2024 19:39:51 GMT	Expired	Expired
`9f8458f`	Wed, 03 Jul 2024 19:12:36 GMT	Expired	Expired
`2a5b927`	Wed, 03 Jul 2024 19:49:02 GMT	Cloud	Enterprise

calvin-codecov

There are a couple instances of describe text blocks that are using the spelling "flaging" instead of "flagging".

Looks great!

Side question out of curiosity about the feature changes: so we're removing breadcrumbs with the new header?

spalmurray-codecov · 2024-07-03T18:58:55Z

The breadcrumbs will return in the new header!

spalmurray-codecov force-pushed the spalmurray/use-new-header-feature-flag branch from 8ea3e0a to 374fb9a Compare June 26, 2024 18:01

spalmurray-codecov marked this pull request as ready for review June 26, 2024 18:33

spalmurray-codecov mentioned this pull request Jun 27, 2024

feat: Implement new header's User dropdown #2973

Merged

calvin-codecov approved these changes Jul 3, 2024

View reviewed changes

spalmurray-codecov added 15 commits July 3, 2024 15:01

Hide old header when flag is true

81ff16e

Hide plan page nav

91087ef

Hide accounts settings nav

2c9cf99

Hide analytics page nav

dd6ddc7

Hide MembersPage nav

7fddfb0

Hide OwnerPage nav

8e1d5f9

Hide Pulls page breadcrumb

ba6357f

Hide commit page breadcrumb

14dae66

Hide admin settings page breadcrumb

9106af3

Hide repo page breadcrumb

a9b0be2

Fix test

be5e7ed

Fix test part 2

c2070b3

Fix other tests

6e89491

Fix tests again

71a7f3c

Fix typos

9f8458f

spalmurray-codecov force-pushed the spalmurray/use-new-header-feature-flag branch from ad48b84 to 9f8458f Compare July 3, 2024 19:02

Fix broken test

2a5b927

spalmurray-codecov added this pull request to the merge queue Jul 3, 2024

Merged via the queue into main with commit db273b3 Jul 3, 2024
61 checks passed

spalmurray-codecov deleted the spalmurray/use-new-header-feature-flag branch July 3, 2024 20:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Hide old header stuff when new header flag is true #2967

feat: Hide old header stuff when new header flag is true #2967

spalmurray-codecov commented Jun 24, 2024 •

edited

Loading

codecov-qa bot commented Jun 24, 2024 •

edited

Loading

codecov-public-qa bot commented Jun 24, 2024 •

edited

Loading

codecov-notifications bot commented Jun 24, 2024 •

edited

Loading

codecov bot commented Jun 24, 2024 •

edited

Loading

codecov-staging bot commented Jun 24, 2024 •

edited

Loading

codecov bot commented Jun 24, 2024 •

edited

Loading

codecov-releaser commented Jun 24, 2024 •

edited

Loading

calvin-codecov left a comment

spalmurray-codecov commented Jul 3, 2024

feat: Hide old header stuff when new header flag is true #2967

feat: Hide old header stuff when new header flag is true #2967

Conversation

spalmurray-codecov commented Jun 24, 2024 • edited Loading

codecov-qa bot commented Jun 24, 2024 • edited Loading

Codecov Report

codecov-public-qa bot commented Jun 24, 2024 • edited Loading

Codecov Report

codecov-notifications bot commented Jun 24, 2024 • edited Loading

Codecov Report

codecov bot commented Jun 24, 2024 • edited Loading

Codecov Report

codecov-staging bot commented Jun 24, 2024 • edited Loading

Bundle Report

codecov bot commented Jun 24, 2024 • edited Loading

Bundle Report

codecov-releaser commented Jun 24, 2024 • edited Loading

✅ Deploy preview for gazebo ready!

calvin-codecov left a comment

Choose a reason for hiding this comment

spalmurray-codecov commented Jul 3, 2024

spalmurray-codecov commented Jun 24, 2024 •

edited

Loading

codecov-qa bot commented Jun 24, 2024 •

edited

Loading

codecov-public-qa bot commented Jun 24, 2024 •

edited

Loading

codecov-notifications bot commented Jun 24, 2024 •

edited

Loading

codecov bot commented Jun 24, 2024 •

edited

Loading

codecov-staging bot commented Jun 24, 2024 •

edited

Loading

codecov bot commented Jun 24, 2024 •

edited

Loading

codecov-releaser commented Jun 24, 2024 •

edited

Loading