feat: Implement new header's User dropdown #2973

spalmurray-codecov · 2024-06-27T20:12:41Z

Implements the UserDropdown for the new Header. For now, this is an almost exact copy the old user dropdown, but we'll move this over to the new Dropdown component once we implement that in codecov/engineering-team#1942. The only difference between this and the old user dropdown is minor spacing change and dark border on the Avatar.

Design

Closes codecov/engineering-team#1952

Screenshot

codecov-qa · 2024-06-27T20:15:58Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.36%. Comparing base (855b1a4) to head (5ea665c).

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #2973   +/-   ##
=======================================
  Coverage   98.36%   98.36%           
=======================================
  Files         890      890           
  Lines       13257    13278   +21     
  Branches     3468     3544   +76     
=======================================
+ Hits        13040    13061   +21     
  Misses        213      213           
  Partials        4        4

Files	Coverage Δ
src/layouts/Header/Header.tsx	`100.00% <100.00%> (ø)`
...ts/Header/components/UserDropdown/UserDropdown.tsx	`100.00% <100.00%> (ø)`
src/layouts/OldHeader/Dropdown.tsx	`100.00% <ø> (ø)`
src/pages/OwnerPage/Header/Header.jsx	`100.00% <ø> (ø)`
...age/routes/CommitsTab/CommitsTable/Title/Title.tsx	`100.00% <ø> (ø)`
...s/RepoPage/CommitsTab/CommitsTable/Title/Title.tsx	`100.00% <ø> (ø)`
...pages/RepoPage/PullsTab/PullsTable/Title/Title.tsx	`100.00% <ø> (ø)`
src/ui/Avatar/Avatar.jsx	`100.00% <100.00%> (ø)`
src/ui/ContextSwitcher/ContextSwitcher.jsx	`100.00% <ø> (ø)`

... and 1 file with indirect coverage changes

Components	Coverage Δ
Assets	`53.84% <ø> (ø)`
Layouts	`97.41% <100.00%> (+0.17%)`	⬆️
Pages	`99.16% <ø> (ø)`
Services	`99.46% <ø> (ø)`
Shared	`99.69% <ø> (ø)`
UI	`94.58% <100.00%> (-0.01%)`	⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 855b1a4...5ea665c. Read the comment docs.

codecov-public-qa · 2024-06-27T20:16:01Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.36%. Comparing base (855b1a4) to head (5ea665c).

✅ All tests successful. No failed tests found ☺️

@@           Coverage Diff           @@
##             main    #2973   +/-   ##
=======================================
  Coverage   98.36%   98.36%           
=======================================
  Files         890      890           
  Lines       13257    13278   +21     
  Branches     3514     3473   -41     
=======================================
+ Hits        13040    13061   +21     
  Misses        213      213           
  Partials        4        4

Files	Coverage Δ
src/layouts/Header/Header.tsx	`100.00% <100.00%> (ø)`
...ts/Header/components/UserDropdown/UserDropdown.tsx	`100.00% <100.00%> (ø)`
src/layouts/OldHeader/Dropdown.tsx	`100.00% <ø> (ø)`
src/pages/OwnerPage/Header/Header.jsx	`100.00% <ø> (ø)`
...age/routes/CommitsTab/CommitsTable/Title/Title.tsx	`100.00% <ø> (ø)`
...s/RepoPage/CommitsTab/CommitsTable/Title/Title.tsx	`100.00% <ø> (ø)`
...pages/RepoPage/PullsTab/PullsTable/Title/Title.tsx	`100.00% <ø> (ø)`
src/ui/Avatar/Avatar.jsx	`100.00% <100.00%> (ø)`
src/ui/ContextSwitcher/ContextSwitcher.jsx	`100.00% <ø> (ø)`

... and 1 file with indirect coverage changes

Components	Coverage Δ
Assets	`53.84% <ø> (ø)`
Layouts	`97.41% <100.00%> (+0.17%)`	⬆️
Pages	`99.16% <ø> (ø)`
Services	`99.46% <ø> (ø)`
Shared	`99.69% <ø> (ø)`
UI	`94.58% <100.00%> (-0.01%)`	⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 855b1a4...5ea665c. Read the comment docs.

codecov · 2024-06-27T20:16:02Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.36%. Comparing base (855b1a4) to head (5ea665c).

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@             Coverage Diff             @@
##               main      #2973   +/-   ##
===========================================
  Coverage   98.36000   98.36000           
===========================================
  Files           890        890           
  Lines         13257      13278   +21     
  Branches       3533       3473   -60     
===========================================
+ Hits          13040      13061   +21     
  Misses          213        213           
  Partials          4          4

Files	Coverage Δ
src/layouts/Header/Header.tsx	`100.00% <100.00%> (ø)`
...ts/Header/components/UserDropdown/UserDropdown.tsx	`100.00% <100.00%> (ø)`
src/layouts/OldHeader/Dropdown.tsx	`100.00% <ø> (ø)`
src/pages/OwnerPage/Header/Header.jsx	`100.00% <ø> (ø)`
...age/routes/CommitsTab/CommitsTable/Title/Title.tsx	`100.00% <ø> (ø)`
...s/RepoPage/CommitsTab/CommitsTable/Title/Title.tsx	`100.00% <ø> (ø)`
...pages/RepoPage/PullsTab/PullsTable/Title/Title.tsx	`100.00% <ø> (ø)`
src/ui/Avatar/Avatar.jsx	`100.00% <100.00%> (ø)`
src/ui/ContextSwitcher/ContextSwitcher.jsx	`100.00% <ø> (ø)`

... and 1 file with indirect coverage changes

Components	Coverage Δ
Assets	`53.84% <ø> (ø)`
Layouts	`97.41% <100.00%> (+0.17%)`	⬆️
Pages	`99.16% <ø> (ø)`
Services	`99.46% <ø> (ø)`
Shared	`99.69% <ø> (ø)`
UI	`94.58% <100.00%> (-0.01%)`	⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 855b1a4...5ea665c. Read the comment docs.

codecov-notifications · 2024-06-27T20:16:08Z

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #2973   +/-   ##
=======================================
  Coverage   98.36%   98.36%           
=======================================
  Files         890      890           
  Lines       13257    13278   +21     
  Branches     3538     3539    +1     
=======================================
+ Hits        13040    13061   +21     
  Misses        213      213           
  Partials        4        4

Files	Coverage Δ
src/layouts/Header/Header.tsx	`100.00% <100.00%> (ø)`
...ts/Header/components/UserDropdown/UserDropdown.tsx	`100.00% <100.00%> (ø)`
src/layouts/OldHeader/Dropdown.tsx	`100.00% <ø> (ø)`
src/pages/OwnerPage/Header/Header.jsx	`100.00% <ø> (ø)`
...age/routes/CommitsTab/CommitsTable/Title/Title.tsx	`100.00% <ø> (ø)`
...s/RepoPage/CommitsTab/CommitsTable/Title/Title.tsx	`100.00% <ø> (ø)`
...pages/RepoPage/PullsTab/PullsTable/Title/Title.tsx	`100.00% <ø> (ø)`
src/ui/Avatar/Avatar.jsx	`100.00% <100.00%> (ø)`
src/ui/ContextSwitcher/ContextSwitcher.jsx	`100.00% <ø> (ø)`

... and 1 file with indirect coverage changes

Components	Coverage Δ
Assets	`53.84% <ø> (ø)`
Layouts	`97.41% <100.00%> (+0.17%)`	⬆️
Pages	`99.16% <ø> (ø)`
Services	`99.46% <ø> (ø)`
Shared	`99.69% <ø> (ø)`
UI	`94.58% <100.00%> (-0.01%)`	⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 855b1a4...5ea665c. Read the comment docs.

codecov-staging · 2024-06-27T20:17:37Z

Bundle Report

Changes will increase total bundle size by 2.75kB ⬆️

Bundle name	Size	Change
gazebo-staging-array-push	6.74MB	2.75kB ⬆️

codecov · 2024-06-27T20:17:53Z

Bundle Report

Changes will increase total bundle size by 2.75kB ⬆️

Bundle name	Size	Change
gazebo-production-array-push	6.74MB	2.75kB ⬆️

codecov-releaser · 2024-06-27T20:24:20Z

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit	Created	Cloud	Enterprise
`25eff52`	Thu, 27 Jun 2024 20:24:20 GMT	Expired	Expired
`5ea665c`	Thu, 04 Jul 2024 12:56:29 GMT	Expired	Expired
`5ea665c`	Thu, 04 Jul 2024 13:06:38 GMT	Cloud	Enterprise

nicholas-codecov

LGTM

spalmurray-codecov force-pushed the spalmurray/new-header-user-dropdown branch from 25eff52 to bfd31e3 Compare July 4, 2024 12:39

spalmurray-codecov added 4 commits July 4, 2024 08:49

Update Avatar to have light and dark border option

49fa235

Implement user drop down + misc fixes

78f55d5

Fix useUser usage

8f3be9f

Update Avatar's border prop

5ea665c

spalmurray-codecov force-pushed the spalmurray/new-header-user-dropdown branch from bfd31e3 to 5ea665c Compare July 4, 2024 12:49

spalmurray-codecov marked this pull request as ready for review July 4, 2024 13:22

nicholas-codecov approved these changes Jul 5, 2024

View reviewed changes

spalmurray-codecov added this pull request to the merge queue Jul 5, 2024

Merged via the queue into main with commit 56cb7d3 Jul 5, 2024
61 checks passed

spalmurray-codecov deleted the spalmurray/new-header-user-dropdown branch July 5, 2024 13:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Implement new header's User dropdown #2973

feat: Implement new header's User dropdown #2973

spalmurray-codecov commented Jun 27, 2024 •

edited

Loading

codecov-qa bot commented Jun 27, 2024 •

edited

Loading

codecov-public-qa bot commented Jun 27, 2024 •

edited

Loading

codecov bot commented Jun 27, 2024 •

edited

Loading

codecov-notifications bot commented Jun 27, 2024 •

edited

Loading

codecov-staging bot commented Jun 27, 2024 •

edited

Loading

codecov bot commented Jun 27, 2024 •

edited

Loading

codecov-releaser commented Jun 27, 2024 •

edited

Loading

nicholas-codecov left a comment

feat: Implement new header's User dropdown #2973

feat: Implement new header's User dropdown #2973

Conversation

spalmurray-codecov commented Jun 27, 2024 • edited Loading

Screenshot

codecov-qa bot commented Jun 27, 2024 • edited Loading

Codecov Report

codecov-public-qa bot commented Jun 27, 2024 • edited Loading

Codecov Report

codecov bot commented Jun 27, 2024 • edited Loading

Codecov Report

codecov-notifications bot commented Jun 27, 2024 • edited Loading

Codecov Report

codecov-staging bot commented Jun 27, 2024 • edited Loading

Bundle Report

codecov bot commented Jun 27, 2024 • edited Loading

Bundle Report

codecov-releaser commented Jun 27, 2024 • edited Loading

✅ Deploy preview for gazebo ready!

nicholas-codecov left a comment

Choose a reason for hiding this comment

spalmurray-codecov commented Jun 27, 2024 •

edited

Loading

codecov-qa bot commented Jun 27, 2024 •

edited

Loading

codecov-public-qa bot commented Jun 27, 2024 •

edited

Loading

codecov bot commented Jun 27, 2024 •

edited

Loading

codecov-notifications bot commented Jun 27, 2024 •

edited

Loading

codecov-staging bot commented Jun 27, 2024 •

edited

Loading

codecov bot commented Jun 27, 2024 •

edited

Loading

codecov-releaser commented Jun 27, 2024 •

edited

Loading