feat: Update Edit Payment Card Component to use Stripe Card Element #2911
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #2911 +/- ##
==========================================
- Coverage 98.48% 98.46% -0.03%
==========================================
Files 882 886 +4
Lines 13074 13122 +48
Branches 3503 3505 +2
==========================================
+ Hits 12876 12920 +44
- Misses 194 198 +4
Partials 4 4
... and 13 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #2911 +/- ##
==========================================
- Coverage 98.48% 98.46% -0.03%
==========================================
Files 882 886 +4
Lines 13074 13122 +48
Branches 3503 3510 +7
==========================================
+ Hits 12876 12920 +44
- Misses 194 198 +4
Partials 4 4
... and 13 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #2911 +/- ##
==========================================
- Coverage 98.48% 98.46% -0.03%
==========================================
Files 882 886 +4
Lines 13074 13122 +48
Branches 3484 3510 +26
==========================================
+ Hits 12876 12920 +44
- Misses 194 198 +4
Partials 4 4
... and 13 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Bundle ReportChanges will increase total bundle size by 312.19kB ⬆️
|
Bundle ReportChanges will increase total bundle size by 312.19kB ⬆️
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #2911 +/- ##
================================================
- Coverage 98.48000 98.46000 -0.02000
================================================
Files 882 886 +4
Lines 13074 13122 +48
Branches 3484 3510 +26
================================================
+ Hits 12876 12920 +44
- Misses 194 198 +4
Partials 4 4
... and 13 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Description
Updates the payment card component from using the split payment card to the single line Card Element. Also fixes a bug where the error message was just showing an empty banner (potentially regression from the stripe version upgrades?)
This also updates the email styling from the "billing" style to the "default" style.
Closes codecov/engineering-team#1779
Closes codecov/engineering-team#1759
Notable Changes
Screenshots
BEFORE
AFTER
Link to Sample Entry
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.