Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the old inconsistent TextInput field on the billing page #1759

Closed
Tracked by #2057
Adal3n3 opened this issue May 16, 2024 · 4 comments · Fixed by codecov/gazebo#2911
Closed
Tracked by #2057

Update the old inconsistent TextInput field on the billing page #1759

Adal3n3 opened this issue May 16, 2024 · 4 comments · Fixed by codecov/gazebo#2911
Assignees
Labels
Dev-Ready This means the UX is reviewed and ready for prioritization scheduling. Polish polish, tweaks, and bug issues that are small iterations and/or not part of larger quarterly epics

Comments

@Adal3n3
Copy link

Adal3n3 commented May 16, 2024

Problem to solve

In the billing page, we have these two form fields - email and payment method are using the old version of TextInput.
Screenshot 2024-05-16 at 1 16 52 PM

Possible solution

Swap the old TextInout fields to the one in Storybook.
Storybook: https://5fa9228f77839a00217f8a45-skelcuitot.chromatic.com/?path=/docs/components-textinput--docs
Screenshot 2024-05-16 at 1 17 03 PM

@Adal3n3 Adal3n3 added Dev-Ready This means the UX is reviewed and ready for prioritization scheduling. Polish polish, tweaks, and bug issues that are small iterations and/or not part of larger quarterly epics labels May 16, 2024
@Adal3n3 Adal3n3 self-assigned this May 16, 2024
@Adal3n3
Copy link
Author

Adal3n3 commented May 16, 2024

We will create another inconsistent TextInput when we release the cardholder name, address, phone number section on #1506
Screenshot 2024-05-16 at 1 27 57 PM

@katia-sentry @ajay-sentry @aj-codecov This ask is focusing on the style only.

@Adal3n3 Adal3n3 removed their assignment May 16, 2024
@Adal3n3
Copy link
Author

Adal3n3 commented May 20, 2024

@katia-sentry Can you assign this?

@ajay-sentry
Copy link

From 5/23 sync, we want to update this component to the one line CardElement from stripe. This should be a plug and play with the existing backend logic; just need to update some code here: https://github.com/codecov/gazebo/blob/eefdefe3f5d26e8209760674e5ce3d9863e6eb4b/src/pages/PlanPage/subRoutes/CurrentOrgPlan/BillingDetails/PaymentCard/CreditCardForm.jsx#L43-L54

Additionally, turn off Link and Zip Code.

@ajay-sentry
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dev-Ready This means the UX is reviewed and ready for prioritization scheduling. Polish polish, tweaks, and bug issues that are small iterations and/or not part of larger quarterly epics
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants