-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feedback about setting up your repo #18
Comments
The repo setup page includes this note:
The codecov-action says this though:
I tried it without the token and it did not work, so I'm going to follow the instructions under the codecov-action instead of the setup repo instructions. |
The setup for multi-module maven projects with jacoco isn't as intuitive as I'd like, so some more documentation would reduce friction when adding new projects. The basic upload works well, but I'd also like to capture cross-module coverage for cases where module A uses module B heavily in the tests. The current behaviour seems to only consider same-module coverage in the final report, which is often appropriate, but is misleading in my case. |
too hard i dont need Ci bruh |
Some repo is deleted and never upload. It always display on my Dashboard. |
Spelling mistake: I assume "Tour" is "Your" As for Documentation. Its quite vague and unclear on expectations on how for example you want the users to publish their code coverage along side Codecov. May I suggest you take the time to publish some example simple "Actions.yml" / examples for people to view and make use of. |
Worked great. |
omg. that is the worst setup experience.
|
"Step 3: add Codecov to your GitHub Actions workflow" okay, how? |
It would be good to know where in the workflow this should be added, or does it not matter? |
The documentation refers to "pull request" in step 4 What pull request? I've just created repo and pushed stuff directly to the trunk, there are no pull requests. Do there need to be? I've completed all the steps in the GitHub actions successfully I think, but the repo list still says "not yet enabled". How do I debug this? Step 4 says "Once you've committed your changes in Step 2". I don't think anything is committed is it? You just setup and enable the app . Does something need to be committed in the repo? This page https://docs.codecov.com/docs/quick-start specifically shows something different for step 3:
vs
Which is right? |
@jayber sorry for my delay, just noticing this. Thanks for the feedback.
No, it doesn't require a pull request. However, commonly configuration would be done with a PR workflow, but it sounds like you committed directly to the head. We mention the PR in step 4 is because there is a PR comment coverage report and status check.
If you go to your action and look at workflow, you may see the following: Could you send the output of the CI step where you're uploading the coverage?
Sorry for the confusion here. The reason there is a diff is because the first one is more specific to GitHub actions CI and the other is generic CI. The Codecov GitHub action is a wrapper for the same instructions in the quick start guide. We will be following up to update our docs to be more clear about this. Thanks for the feedback 🙏 |
I've got codecov working fine with several public repositories but I can't get it working with one private repo - I always get the same error. I have done:
But running that step results in this (I've only replaced the name of the repo with
|
Thanks @philgyford I also needed to add:
to my GitHub Action. Before adding that I was getting:
Now it succeeds:
And I can now see the analysis over on the codecov.io website. The instructions for GitHub Actions should be amended to also state the |
Thanks @gregorywilliams but I already had that in the example of my code I showed, or do you mean it needs to go somewhere else? - name: Upload Coverage to Codecov
uses: codecov/codecov-action@v3
with:
token: ${{ secrets.CODECOV_TOKEN }} |
@philgyford I was agreeing that I'd also needed to add the same and thanking you for mentioning it. When I set up Codecov against my repo their instructions neglected to mention the |
@gregorywilliams Unfortunately it's not the resolution for me, because I have the |
@gregorywilliams that's right, and we'll be adding this input to the repo guide page ✅ @philgyford I'm unsure what the issue is based on your post. Could you reach out to our support team ? |
As a member of an org that had just passed its seat limit, I could not get a new repo to show up in the dashboard list, although initiating the request to add the repo to codecov's permissioned set showed no errors. It took an admin (CTO) digging into the codecov dashboard to discover I had an "inactive" status, which, perhaps was causing the permission update to fail? Not sure, but nothing in my UI indicated that anything was amiss. Better error/status reporting to make it clear what we needed to do would have saved some c-suite guesswork! |
@larryaasen @JohannLai @enraiha0307 thank you for raising the syntax error. The fix in live: |
Hello dear team, I think you should mention two things clearly:
Now my question (to which I'm trying to find an answer) is: Where does the action get the coverage files to upload? I think the answer is in the docs of the action itself, but I'm still investigating (spending time in something that should have clarified since the start by the docs). |
I'm still confused about how to specify the token required for private repositories. The codecov-action README says: - name: Upload coverage to Codecov
uses: codecov/codecov-action@v3
with:
token: ${{ secrets.CODECOV_TOKEN }} The example in the website docs is like: - name: Upload coverage reports to Codecov
run: |
# Replace `linux` below with the appropriate OS
# Options are `alpine`, `linux`, `macos`, `windows`
curl -Os https://uploader.codecov.io/latest/linux/codecov
chmod +x codecov
./codecov -t ${CODECOV_TOKEN} The examples in the above comments – including a screenshot of a correct version from @codecovdesign – are like this (I don't know which docs the screenshot is taken from): - name: Upload coverage reports to Codecov
uses: codecov/codecov-action@v3
env:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} Are all of these correct? Or two of them? Or only one of them? If the latter, could they all be kept in sync? |
@Aerendir thank you for your feedback! Based on it, I'm creating some updates to the copy to be more clear in the documentation / setup guide 🙏 .
The action does not run the test, rather after running tests in the CI and generating coverage reports, it upload coverage data to Codecov.
It will get the reports from the CI test run. If the CI isn't configured to output coverage reports, you'll need to configure this in your testing tool. |
@philgyford that is confusing and thanks for raising 🙏 . |
@codecovdesign Thanks. One thing though – you say "the 2nd input is generic for other CIs" but it's introduced with "An example of a workflow using the uploader with GitHub Actions is shown below." Which would make me think that's how to set things up with GitHub Actions? |
I am finding the setup experience confusing.
and then it leaves it at that as if that's all the setup that's needed, but this does not seem to be enough, because it does not generate coverage information, does not set up badges, etc. |
This has been an arduous slog to get setup. I am using CircleCI, Orb v4.0.0 and (still) attempting to get the results piped to github. Issues I've run into:
Not sure if there will be more issues when I can actually get a report uploaded but I'm very close to ditching Codecov and choosing another solution |
Hi @IanHoar,
Is there anything else you are running into that I can help you with? |
Thanks your @ErikBjare for the report 🙏 . I created a bug issues to investigate and fix: codecov/engineering-team#1171 |
I get a "There is an error processing the coverage reports." and "unusable report" when trying to upload a jacoco test report (xml). It is completely unclear for me, why this report is unusable (works locally). |
@PinkieSwirl thank you for sharing and sorry to hear about the issue. Could you link a screenshot of the error? It will help me investigate the issue further 🙏 (codecov/engineering-team#1187) |
I am setting up a C++ project (cmake) with GitHub actions. The documentation says to add this to actions:
|
@jberkenbilt thank you for the feedback 🙏
Noted. cc'ing @rohan-at-sentry wdyt^ would this be any breaking changes? If not, we can open a polish issue.
@jberkenbilt did you previous deactivate the repo in settings? It sounds like that wasn't the case, but wanted to confirm ahead of debugging why it showed that way. |
@codecovdesign No, I didn't deactivate it. I was just poking around and noticed it said it was deactivated, then activated. Then it occurred to me that I should have left it to see whether it would activate on its own. |
Github actions build succeeds but I don't see lcov file uploading here's the actions Edit: I have been able to setup flutter test coverage reports |
Codecov is right away complaining about unknown token:
Without the token, it couldn't fetch the build:
UpdateApparently, there are 2 different tokens: the one from «Let's get your repor covered» does not work. The one from the «Settings» tab does |
For some reason the repo was deactivated on codecov, after activating it, and installing the codecov app on my repo I started getting the error Double checked all data, everything seems to be in place. |
Once merged to your default branch, subsequent pull requests will have Codecov checks and comments. Additionally, you’ll find your repo coverage dashboard here. If you have merged try reloading the page.Once merged to your default branch, subsequent pull requests will have Codecov checks and comments. Additionally, you’ll find your repo coverage dashboard here. If you have merged try reloading the page. |
Codecov 4.1.0 doesn't work but 3.1.4 doesSetup following your latest instructions does not work when running GitHub Actions in a I do all of my development, testing, and deployments in a Docker Steps to reproduceIf you want to reproduce this just fork my repo: nyu-devops/lab-github-actions and uncomment the Codecov step at the bottom of You can also probably recreate this yourself by using a jobs:
build:
runs-on: ubuntu-latest
container: python:3.11-slim QuestionCan you please document what Codecov 4.0.1 needs in the Linux environment that 3.1.4 doesn't so that I can install those Linux components before running Codecov. From the logs it looks like it needs: BTW, v4.5.0 looks even worse. It looks like it is expecting Logs from Codecov 4.1.0
Logs from Codecov 4.5.0
|
In a monorepo, on gitlab, using turbo and vitest, I'm not able to transfer coverage data. All attempts end with:
|
The github actions pytest instruction on the configuration page is wrong I had to change it to And the github workflow action to:
|
gitlab and bun with monorepo |
I've not been able to set up my GirHub SquareDanceReasoning repo on Codecov. I've successfully set up other repositories, but, though I think I've followed all of the instructions, this repo is still not configured. I wish you provided diagnostics information so one could attempt to identify where things are going wrong. Don't be a black box. |
For my Rails 8 project, this did not work out of the box. Rspec with simplecov
Run codecov/codecov-action@v4
... which is unfortunate because this vscode plugin displays the coverage beautifully: https://marketplace.visualstudio.com/items?itemName=dewski.simplecov The example-app seems to require a not-updated-in-3-years XML converter. See: https://github.com/codecov/example-ruby/blob/main/test/test_helper.rb#L6-L7 ... so I guess I'll give that a try next, but it is a shame Codecov can't read the |
Thanks for dropping by! 👋
We've been working on improving the repo configuration and set up..
We greatly appreciate your time and thoughts - looking forward to hearing from you ❤
Codecov team
This issue is intended to share and collect feedback about the tool. If you have support needs or questions, please see our support page.
The text was updated successfully, but these errors were encountered: