Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax error repo guide step 2 #1171

Closed
codecovdesign opened this issue Feb 12, 2024 · 2 comments · Fixed by codecov/gazebo#2599
Closed

Syntax error repo guide step 2 #1171

codecovdesign opened this issue Feb 12, 2024 · 2 comments · Fixed by codecov/gazebo#2599
Assignees
Labels
bug Something isn't working investigation

Comments

@codecovdesign
Copy link
Contributor

codecovdesign commented Feb 12, 2024

Describe the bug
In the repo guide page there is a slight syntax error, here is the current:

- name: Upload coverage reports to Codecov
  uses: codecov/[email protected]
  env:
    token: ${{ secrets.CODECOV_TOKEN }}
    slug: Turing-Example/example_private

reported here: codecov/feedback#18 (comment)

Expected behavior
the env: should be with:

However, it appears both are interchageable, but one or the other may not work in certain circumstances.

https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsenv
and
https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepswith

Further investigation is needed to determine why both don't work interchangeably.

@idjaw
Copy link

idjaw commented Feb 12, 2024

I'm not sure what scenarios would make env work, but thought I'd add that I just experienced this issue setting up for the first time, and changing to with resolved my issue. If there is anything you would like me to test in using env, let me know, I can give it a shot.

@codecovdesign
Copy link
Contributor Author

Thank you @idjaw for the feedback!
We are going to update to with and then troubleshoot the env.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working investigation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants