Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use nx-verdaccio for e2e testing #842

Merged
merged 57 commits into from
Nov 5, 2024
Merged
Show file tree
Hide file tree
Changes from 21 commits
Commits
Show all changes
57 commits
Select commit Hold shift + click to select a range
d1137f1
update nxv
BioPhoton Oct 14, 2024
b7b604b
wip
BioPhoton Oct 14, 2024
678c397
install nx-verdaccio
BioPhoton Oct 15, 2024
95ccd85
test: use nx-verdaccio for lh e2e tests
BioPhoton Oct 15, 2024
88657bb
refactor: reduce implicit deps to direct ones
BioPhoton Oct 15, 2024
6b9c655
refactor: use project type library for projects that are packages
BioPhoton Oct 15, 2024
c0bc072
refactor: remove old test setup
BioPhoton Oct 15, 2024
9f1431d
fix: hack to not get filtered out of the task graph
BioPhoton Oct 15, 2024
e87fe8d
refactor: set env root
BioPhoton Oct 15, 2024
bcbc934
refactor: remove old test setup
BioPhoton Oct 15, 2024
14b023b
refactor: update packages
BioPhoton Oct 15, 2024
ba75e0b
wip
BioPhoton Oct 15, 2024
5ffa5fa
wip
BioPhoton Oct 15, 2024
2cfb8e1
wip
BioPhoton Oct 15, 2024
0b5c494
update packages
BioPhoton Oct 15, 2024
f4e585c
fix
BioPhoton Oct 15, 2024
ed2de53
fix
BioPhoton Oct 15, 2024
f820746
fix final
BioPhoton Oct 15, 2024
beba766
fix final 2
BioPhoton Oct 15, 2024
fb61859
fix final 3
BioPhoton Oct 15, 2024
3dd9408
fix final last
BioPhoton Oct 15, 2024
6cdf7cc
cleanup
BioPhoton Oct 15, 2024
6f15a22
Merge branch 'main' into use-nx-verdaccio-for-e2e-testing
BioPhoton Oct 15, 2024
da33933
refactor ci-e2e project to new test helper
BioPhoton Oct 15, 2024
1ad7db4
update nxv
BioPhoton Oct 15, 2024
2783e4c
Merge branch 'main' into use-nx-verdaccio-for-e2e-testing
BioPhoton Oct 16, 2024
e4f653c
Merge branch 'main' into use-nx-verdaccio-for-e2e-testing
BioPhoton Oct 17, 2024
3cd813f
Merge branch 'main' into use-nx-verdaccio-for-e2e-testing
BioPhoton Oct 17, 2024
0f8e07f
wip
BioPhoton Oct 17, 2024
671d84f
update nxv
BioPhoton Oct 18, 2024
97c8d30
merge main
BioPhoton Oct 18, 2024
7baef98
update nxv (mark released packages with publisher prop)
BioPhoton Oct 18, 2024
91f3677
fix e2e
BioPhoton Oct 18, 2024
8972f0c
format
BioPhoton Oct 18, 2024
8ed31b3
test 1
BioPhoton Oct 18, 2024
0c74bdf
test 2
BioPhoton Oct 18, 2024
79c99e8
wip
BioPhoton Oct 18, 2024
f1e3e02
format
BioPhoton Oct 18, 2024
26d8ee5
update nxv
BioPhoton Oct 19, 2024
e10eba6
test: command with npx
vmasek Oct 21, 2024
f55b53d
test: use spawn window hide option
vmasek Oct 21, 2024
23402e0
test: use warn log instead of error for test folder teardown
vmasek Oct 21, 2024
8b828ad
update nxv
BioPhoton Oct 22, 2024
dabf389
fix pkg1
BioPhoton Oct 22, 2024
7864995
fix pkg1
BioPhoton Oct 23, 2024
71a8ffb
fix pkg1
BioPhoton Oct 23, 2024
5d12d9a
fix pkg1
BioPhoton Oct 23, 2024
612d227
fix pkg2
BioPhoton Oct 23, 2024
17249d8
Merge branch 'main' into use-nx-verdaccio-for-e2e-testing
BioPhoton Oct 23, 2024
7f04139
fix pkg2
BioPhoton Oct 23, 2024
d1a6498
chore: sync package-lock with package.json
hanna-skryl Oct 23, 2024
e985db0
fix: update lockfile to resolve missing deps
hanna-skryl Oct 23, 2024
a4d9543
fix: resolve tslib version mismatch
hanna-skryl Oct 23, 2024
7f0bda7
fix: remove unused catch binding
hanna-skryl Oct 23, 2024
2d1d772
test: add portal-client for upload executor
hanna-skryl Oct 24, 2024
61af9e1
test: remove portal-client
hanna-skryl Oct 24, 2024
a1d01d8
test(nx-plugin-e2e): rm upload test; portal-client required
hanna-skryl Oct 29, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ jobs:
- name: Install dependencies
run: npm ci
- name: E2E test affected projects
run: npx nx affected:e2e --parallel=1
run: npx nx affected -t nxv-e2e --exclude cli-e2e --parallel=1
matejchalk marked this conversation as resolved.
Show resolved Hide resolved
- name: E2E test cli-e2e project (due to bugs in the setup it has to run last :( )
run: npx nx run cli-e2e:e2e-old

Expand Down
1 change: 0 additions & 1 deletion e2e/create-cli-e2e/vite.config.e2e.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ export default defineConfig({
},
environment: 'node',
include: ['tests/**/*.e2e.test.{js,mjs,cjs,ts,mts,cts,jsx,tsx}'],
globalSetup: ['../../global-setup.verdaccio.ts'],
setupFiles: ['../../testing/test-setup/src/lib/reset.mocks.ts'],
},
});
9 changes: 1 addition & 8 deletions e2e/nx-plugin-e2e/project.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,6 @@
}
}
},
"implicitDependencies": [
"test-utils",
"models",
"utils",
"core",
"cli",
"nx-plugin"
],
"implicitDependencies": ["test-utils", "nx-plugin"],
"tags": ["scope:tooling", "type:e2e"]
}
1 change: 0 additions & 1 deletion e2e/nx-plugin-e2e/vite.config.e2e.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ export default defineConfig({
},
environment: 'node',
include: ['tests/**/*.e2e.test.{js,mjs,cjs,ts,mts,cts,jsx,tsx}'],
globalSetup: ['../../global-setup.verdaccio.ts'],
setupFiles: ['../../testing/test-setup/src/lib/reset.mocks.ts'],
},
});
8 changes: 1 addition & 7 deletions e2e/plugin-lighthouse-e2e/project.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,6 @@
}
}
},
"implicitDependencies": [
"models",
"utils",
"core",
"cli",
"plugin-lighthouse"
],
"implicitDependencies": ["cli", "plugin-lighthouse"],
"tags": ["scope:plugin", "type:e2e"]
}
1 change: 0 additions & 1 deletion e2e/plugin-lighthouse-e2e/vite.config.e2e.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ export default defineConfig({
},
environment: 'node',
include: ['tests/**/*.e2e.test.{js,mjs,cjs,ts,mts,cts,jsx,tsx}'],
globalSetup: ['../../global-setup.verdaccio.ts'],
setupFiles: ['../../testing/test-setup/src/lib/reset.mocks.ts'],
},
});
15 changes: 15 additions & 0 deletions nx.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,9 @@
"e2e": {
"dependsOn": ["^build"]
},
"nxv-env-setup": {
"executor": "@push-based/nx-verdaccio:env-setup"
},
"@nx/vite:test": {
"cache": true,
"inputs": ["default", "^production"],
Expand Down Expand Up @@ -111,6 +114,18 @@
"releaseTagPattern": "v{version}"
},
"plugins": [
{
"plugin": "@push-based/nx-verdaccio",
"options": {
"environments": {
"environmentsDir": "tmp/e2e",
"targetNames": ["e2e"]
},
"packages": {
"filterByTags": ["publishable"]
}
}
},
"./tools/src/debug/debug.plugin.ts",
{
"plugin": "./tools/src/npm/npm.plugin.ts",
Expand Down
Loading
Loading