Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use nx-verdaccio for e2e testing #842

Merged
merged 57 commits into from
Nov 5, 2024

Conversation

BioPhoton
Copy link
Collaborator

@BioPhoton BioPhoton commented Oct 15, 2024

This PR uses nx-verdaccio for all but cli-e2e project. In a follow up PR #844 the e2e-old target gets refactored and the tooling code gets a cleanup

Copy link

github-actions bot commented Oct 15, 2024

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared target commit 4e35719 with source commit 13a63a4.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🟡 54 🟡 52 ↓ −2.1
Updates 🟡 75 🟡 75 ↑ +0.1
Custom checks 🟡 67 🟡 67
Code coverage 🟡 90 🟡 90
Security 🟡 82 🟡 82
Accessibility 🟢 91 🟢 91
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Bug prevention 🟢 100 🟢 100
Code style 🟢 100 🟢 100
👍 1 group improved, 👎 1 group regressed, 👍 3 audits improved, 👎 2 audits regressed, 14 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🟡 54 🟡 52 ↓ −2.1
JS Packages NPM outdated dependencies 🟡 75 🟡 75 ↑ +0.1

18 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Speed Index 🟥 5.8 s 🟥 6.4 s ↑ +9.7 %
Lighthouse Largest Contentful Paint 🟨 3.1 s 🟨 3.3 s ↑ +6.5 %
Lighthouse First Contentful Paint 🟨 3.0 s 🟨 3.0 s ↓ −0.9 %
Lighthouse First Meaningful Paint 🟨 3.0 s 🟨 3.0 s ↓ −0.9 %
JS Packages Outdated NPM dev dependencies. 🟨 57 outdated package versions (33 major, 15 minor, 1 preminor, 7 patch, 1 prerelease) 🟨 57 outdated package versions (33 major, 15 minor, 1 preminor, 7 patch, 1 prerelease)  +0 %
Lighthouse Minimizes main-thread work 🟥 19.7 s 🟥 17.7 s ↓ −10.4 %
Lighthouse Total Blocking Time 🟥 6,320 ms 🟥 5,740 ms ↓ −9.1 %
Lighthouse JavaScript execution time 🟥 9.8 s 🟥 9.5 s ↓ −3 %
Lighthouse Uses efficient cache policy on static assets 🟨 27 resources found 🟨 27 resources found ↓ −0.1 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 70 KiB 🟥 Potential savings of 70 KiB ↑ +100 %
Lighthouse Metrics 🟩 100% 🟩 100% ↑ +0.5 %
Lighthouse Time to Interactive 🟥 15.8 s 🟥 15.8 s ↑ +0.5 %
Lighthouse Eliminate render-blocking resources 🟥 Potential savings of 1,110 ms 🟥 Potential savings of 1,030 ms ↓ −6.7 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 1,812 KiB 🟩 Total size was 1,812 KiB ↓ −0.1 %
Lighthouse Server Backend Latencies 🟩 140 ms 🟩 80 ms ↓ −42.1 %
Lighthouse Max Potential First Input Delay 🟥 2,980 ms 🟥 2,930 ms ↓ −1.6 %
Lighthouse Initial server response time was short 🟩 Root document took 340 ms 🟩 Root document took 370 ms ↑ +7.3 %
Lighthouse Network Round Trip Times 🟩 30 ms 🟩 40 ms ↑ +39.7 %
Lighthouse Avoids an excessive DOM size 🟥 2,232 elements 🟥 2,233 elements ↑ +0.1 %

494 other audits are unchanged.

@github-actions github-actions bot added the 🦾 CI/CD continuous integration and deployment label Oct 15, 2024
@hanna-skryl hanna-skryl force-pushed the use-nx-verdaccio-for-e2e-testing branch from db1caf4 to 2d1d772 Compare October 24, 2024 01:37
Copy link
Collaborator Author

@BioPhoton BioPhoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@matejchalk matejchalk merged commit d61a19d into main Nov 5, 2024
16 checks passed
@matejchalk matejchalk deleted the use-nx-verdaccio-for-e2e-testing branch November 5, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🦾 CI/CD continuous integration and deployment 🔬 testing writing tests 🛠️ tooling 🧩 utils
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants