-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use nx-verdaccio for e2e testing #842
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared target commit 4e35719 with source commit 13a63a4. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories👍 1 group improved, 👎 1 group regressed, 👍 3 audits improved, 👎 2 audits regressed, 14 audits changed without impacting score🗃️ Groups
18 other groups are unchanged. 🛡️ Audits
494 other audits are unchanged. |
BioPhoton
commented
Oct 15, 2024
matejchalk
reviewed
Oct 15, 2024
Signed-off-by: Vojtech Masek <[email protected]>
Signed-off-by: Vojtech Masek <[email protected]>
Signed-off-by: Vojtech Masek <[email protected]>
hanna-skryl
force-pushed
the
use-nx-verdaccio-for-e2e-testing
branch
from
October 24, 2024 01:37
db1caf4
to
2d1d772
Compare
BioPhoton
commented
Oct 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
matejchalk
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses
nx-verdaccio
for all butcli-e2e
project. In a follow up PR #844 thee2e-old
target gets refactored and the tooling code gets a cleanup