Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(cli-e2e): separate e2e tests for lighthouse plugin #809

Merged
merged 45 commits into from
Oct 1, 2024

Conversation

BioPhoton
Copy link
Collaborator

@BioPhoton BioPhoton commented Aug 28, 2024

This PR separates the e2e tests for the lighthous plugin into its own project.

It includes:

  • ➕ add new project plugin-lighthouse-e2e & 🤌 use global-setup.verdaccio.ts
  • 📦 use new e2e test setup
  • 🧹 move omitReportData into test-utils.
  • 🧹 move createNpmWorkspace into test-utils

Copy link

github-actions bot commented Aug 28, 2024

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared target commit 7bf6332 with source commit cddbdd3.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🔴 45 🟡 50 ↑ +4.7
Code coverage 🟡 90 🟡 90 ↓ −0.1
Custom checks 🟡 67 🟡 67
Security 🟡 87 🟡 87
Updates 🟡 78 🟡 78
Accessibility 🟢 91 🟢 91
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Bug prevention 🟢 100 🟢 100
Code style 🟢 99 🟢 99
👍 1 group improved, 👎 1 group regressed, 👍 5 audits improved, 👎 2 audits regressed, 11 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🔴 45 🟡 50 ↑ +4.7
Code coverage Code coverage metrics 🟡 90 🟡 90 ↓ −0.1

18 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Largest Contentful Paint 🟨 3.9 s 🟨 3.5 s ↓ −11.6 %
Lighthouse First Contentful Paint 🟥 3.5 s 🟥 3.0 s ↓ −13.1 %
Lighthouse First Meaningful Paint 🟨 3.5 s 🟨 3.0 s ↓ −13.1 %
Lighthouse Speed Index 🟥 6.6 s 🟥 6.5 s ↓ −2.1 %
Lighthouse Time to Interactive 🟥 16.4 s 🟥 16.0 s ↓ −2 %
Code coverage Line coverage 🟩 91.9 % 🟩 91.4 % ↓ −0.5 %
Code coverage Branch coverage 🟨 85 % 🟨 84.9 % ↓ −0.1 %
Lighthouse Eliminate render-blocking resources 🟥 Potential savings of 1,460 ms 🟥 Potential savings of 290 ms ↓ −80.3 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 1,807 KiB 🟩 Total size was 1,806 KiB ↓ −0.1 %
Lighthouse Total Blocking Time 🟥 7,470 ms 🟥 6,850 ms ↓ −8.2 %
Lighthouse Metrics 🟩 100% 🟩 100% ↓ −2 %
Lighthouse Max Potential First Input Delay 🟥 3,060 ms 🟥 3,330 ms ↑ +8.8 %
Lighthouse Minimizes main-thread work 🟥 21.2 s 🟥 21.0 s ↓ −0.7 %
Lighthouse Uses efficient cache policy on static assets 🟨 27 resources found 🟨 27 resources found ↑ +0.1 %
Lighthouse JavaScript execution time 🟥 9.9 s 🟥 10.0 s ↑ +0.5 %
Lighthouse Initial server response time was short 🟩 Root document took 460 ms 🟩 Root document took 510 ms ↑ +10.4 %
Lighthouse Server Backend Latencies 🟩 120 ms 🟩 140 ms ↑ +14.8 %
Lighthouse Network Round Trip Times 🟩 70 ms 🟩 70 ms ↓ −1.2 %

495 other audits are unchanged.

@BioPhoton BioPhoton marked this pull request as ready for review September 28, 2024 23:13
e2e/create-cli-e2e/tests/init.e2e.test.ts Outdated Show resolved Hide resolved
vmasek
vmasek previously approved these changes Sep 30, 2024
e2e/plugin-lighthouse-e2e/project.json Outdated Show resolved Hide resolved
global-setup.verdaccio.ts Show resolved Hide resolved
vmasek
vmasek previously approved these changes Sep 30, 2024
@BioPhoton BioPhoton removed the request for review from matejchalk September 30, 2024 13:42
matejchalk
matejchalk previously approved these changes Oct 1, 2024
e2e/plugin-lighthouse-e2e/tests/collect.e2e.test.ts Outdated Show resolved Hide resolved
@BioPhoton BioPhoton merged commit 7b6d7da into main Oct 1, 2024
17 checks passed
@BioPhoton BioPhoton deleted the e2e-separate-lighthouse-plugin branch October 1, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants