-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(cli-e2e): separate e2e tests for lighthouse plugin #809
Merged
+443
−199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared target commit 7bf6332 with source commit cddbdd3. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories👍 1 group improved, 👎 1 group regressed, 👍 5 audits improved, 👎 2 audits regressed, 11 audits changed without impacting score🗃️ Groups
18 other groups are unchanged. 🛡️ Audits
495 other audits are unchanged. |
# Conflicts: # e2e/create-cli-e2e/tests/init.e2e.test.ts # global-setup.verdaccio.ts # testing/test-setup/src/lib/test-folder.setup.ts
vmasek
requested changes
Sep 29, 2024
vmasek
previously approved these changes
Sep 30, 2024
matejchalk
reviewed
Sep 30, 2024
Co-authored-by: Matěj Chalk <[email protected]>
vmasek
previously approved these changes
Sep 30, 2024
matejchalk
previously approved these changes
Oct 1, 2024
Co-authored-by: Matěj Chalk <[email protected]>
matejchalk
approved these changes
Oct 1, 2024
vmasek
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR separates the e2e tests for the lighthous plugin into its own project.
It includes:
plugin-lighthouse-e2e
& 🤌 useglobal-setup.verdaccio.ts
omitReportData
intotest-utils
.createNpmWorkspace
intotest-utils