-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(create-cli-e2e): use global-setup.verdaccio.ts in e2e tests and fix enabled test #808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BioPhoton
changed the title
test(creat-cli-e2e): use global-setup.verdaccio.ts, fix enabled test
test(creat-cli-e2e): use global-setup.verdaccio.ts in e2e tests and fix enabled test
Aug 28, 2024
Code PushUpπ₯³ Code PushUp report has improved β compared target commit 380acee with source commit df5c5ac. π΅οΈ See full comparison in Code PushUp portal π π·οΈ Categoriesπ 1 group improved, π 6 audits improved, 12 audits changed without impacting scoreποΈ Groups
19 other groups are unchanged. π‘οΈ Audits495 other audits are unchanged. |
BioPhoton
changed the title
test(creat-cli-e2e): use global-setup.verdaccio.ts in e2e tests and fix enabled test
test(create-cli-e2e): use global-setup.verdaccio.ts in e2e tests and fix enabled test
Aug 28, 2024
# Conflicts: # global-setup.verdaccio.ts # testing/test-setup/src/lib/test-folder.setup.ts
# Conflicts: # e2e/create-cli-e2e/tests/init.e2e.test.ts # e2e/create-cli-e2e/vite.config.e2e.ts
vmasek
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the
create-cli-e2e
project to us the new testing setup. πIt includes:
global-setup.verdaccio.ts
ine2e/create-cli-e2e/vitest.config.ts
asglobalScript
userconfig
param tonpm init @code-pushup/cli
to make it work from a nested folder in the e2e workspacecreate-cli-e2e
rm(dirName, { recursive: true, force: true, maxRetries: 2 });