Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(create-cli-e2e): use global-setup.verdaccio.ts in e2e tests and fix enabled test #808

Merged
merged 30 commits into from
Sep 27, 2024

Conversation

BioPhoton
Copy link
Collaborator

@BioPhoton BioPhoton commented Aug 28, 2024

This PR refactors the create-cli-e2e project to us the new testing setup. πŸŽ‰

It includes:

  • 🀌 use global-setup.verdaccio.ts in e2e/create-cli-e2e/vitest.config.ts as globalScript
  • βž• add userconfig param to npm init @code-pushup/cli to make it work from a nested folder in the e2e workspace
  • πŸ”› enables all other disabled tests in create-cli-e2e
  • ⛑️ deflakes deletion on files with rm(dirName, { recursive: true, force: true, maxRetries: 2 });

@BioPhoton BioPhoton changed the title test(creat-cli-e2e): use global-setup.verdaccio.ts, fix enabled test test(creat-cli-e2e): use global-setup.verdaccio.ts in e2e tests and fix enabled test Aug 28, 2024
Copy link

github-actions bot commented Aug 28, 2024

Code PushUp

πŸ₯³ Code PushUp report has improved – compared target commit 380acee with source commit df5c5ac.

πŸ•΅οΈ See full comparison in Code PushUp portal πŸ”

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score πŸ”„ Score change
Performance πŸ”΄ 35 πŸ”΄ 39 ↑ +4.8
Custom checks 🟑 67 🟑 67 –
Code coverage 🟑 90 🟑 90 –
Security 🟑 87 🟑 87 –
Updates 🟑 78 🟑 78 –
Accessibility 🟒 91 🟒 91 –
Best Practices 🟒 100 🟒 100 –
SEO 🟑 61 🟑 61 –
Bug prevention 🟒 100 🟒 100 –
Code style 🟒 99 🟒 99 –
πŸ‘ 1 group improved, πŸ‘ 6 audits improved, 12 audits changed without impacting score

πŸ—ƒοΈ Groups

πŸ”Œ Plugin πŸ—ƒοΈ Group ⭐ Previous score ⭐ Current score πŸ”„ Score change
Lighthouse Performance πŸ”΄ 35 πŸ”΄ 39 ↑ +4.8

19 other groups are unchanged.

πŸ›‘οΈ Audits

πŸ”Œ Plugin πŸ›‘οΈ Audit πŸ“ Previous value πŸ“ Current value πŸ”„ Value change
Lighthouse Reduce unused CSS πŸŸ₯ Potential savings of 71Β KiB 🟨 Potential savings of 71Β KiB ↓ βˆ’100 %
Lighthouse First Meaningful Paint πŸŸ₯ 4.5Β s 🟨 3.6Β s ↓ βˆ’19.8 %
Lighthouse First Contentful Paint πŸŸ₯ 4.3Β s πŸŸ₯ 3.6Β s ↓ βˆ’16.9 %
Lighthouse Speed Index πŸŸ₯ 10.1Β s πŸŸ₯ 7.9Β s ↓ βˆ’21.8 %
Lighthouse Largest Contentful Paint πŸŸ₯ 5.0Β s πŸŸ₯ 4.5Β s ↓ βˆ’8.1 %
Lighthouse Time to Interactive πŸŸ₯ 21.3Β s πŸŸ₯ 17.2Β s ↓ βˆ’19.2 %
Lighthouse Minimizes main-thread work πŸŸ₯ 31.4Β s πŸŸ₯ 22.9Β s ↓ βˆ’27.3 %
Lighthouse JavaScript execution time πŸŸ₯ 14.5Β s πŸŸ₯ 10.3Β s ↓ βˆ’28.5 %
Lighthouse Metrics 🟩 100% 🟩 100% ↓ βˆ’19.2 %
Lighthouse Total Blocking Time πŸŸ₯ 14,440Β ms πŸŸ₯ 10,700Β ms ↓ βˆ’25.9 %
Lighthouse Max Potential First Input Delay πŸŸ₯ 5,380Β ms πŸŸ₯ 1,960Β ms ↓ βˆ’63.7 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 1,807Β KiB 🟩 Total size was 1,807Β KiB ↑ +0.1 %
Lighthouse Eliminate render-blocking resources πŸŸ₯ Potential savings of 860Β ms πŸŸ₯ Potential savings of 180Β ms ↓ βˆ’78.8 %
Lighthouse Uses efficient cache policy on static assets 🟨 27 resources found 🟨 27 resources found ↑ +0.1 %
Lighthouse Network Round Trip Times 🟩 210Β ms 🟩 80Β ms ↓ βˆ’61.8 %
Lighthouse Server Backend Latencies 🟩 140Β ms 🟩 200Β ms ↑ +45.8 %
Lighthouse Initial server response time was short 🟩 Root document took 420Β ms 🟩 Root document took 410Β ms ↓ βˆ’1.9 %
Lighthouse Avoids an excessive DOM size πŸŸ₯ 2,249 elements πŸŸ₯ 2,248 elements ↓ βˆ’0.1 %

495 other audits are unchanged.

@BioPhoton BioPhoton changed the title test(creat-cli-e2e): use global-setup.verdaccio.ts in e2e tests and fix enabled test test(create-cli-e2e): use global-setup.verdaccio.ts in e2e tests and fix enabled test Aug 28, 2024
@BioPhoton BioPhoton marked this pull request as ready for review September 25, 2024 14:05
@BioPhoton BioPhoton merged commit 5f7b758 into main Sep 27, 2024
17 checks passed
@BioPhoton BioPhoton deleted the create-cli-tests-fix branch September 27, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants