Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(plugin-eslint,cli-e2e): use fewer lint rules in tests #759

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

matejchalk
Copy link
Collaborator

Closes #558

Removed ~750 lines in total from 3 different snapshots.

@github-actions github-actions bot added 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests 🧩 eslint-plugin 🛠️ tooling labels Jul 22, 2024
@matejchalk matejchalk removed 📖 Project documentation improvements or additions to the project documentation 🛠️ tooling labels Jul 22, 2024
Copy link

Code PushUp

😟 Code PushUp report has regressed – compared target commit defdba6 with source commit 9826945.

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🟡 53 🔴 42 ↓ −10.8
Code coverage 🟡 89 🟡 89 ↓ −0.1
Accessibility 🟢 91 🟢 91
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Bug prevention 🟢 100 🟢 100
Code style 🟢 99 🟢 99
Security 🟢 100 🟢 100
Updates 🟡 78 🟡 78
Custom checks 🟡 67 🟡 67

🗃️ Groups

👎 2 groups regressed
🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🟡 53 🔴 42 ↓ −10.8
Code coverage Code coverage metrics 🟡 89 🟡 89 ↓ −0.1

18 other groups are unchanged.

🛡️ Audits

👎 6 audits regressed, 13 audits changed without impacting score
🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Speed Index 🟥 5.9 s 🟥 8.3 s ↑ +41 %
Lighthouse Largest Contentful Paint 🟨 3.2 s 🟥 4.2 s ↑ +29 %
Lighthouse First Contentful Paint 🟨 2.9 s 🟥 3.4 s ↑ +14 %
Lighthouse First Meaningful Paint 🟨 2.9 s 🟨 3.4 s ↑ +17 %
Lighthouse Time to Interactive 🟥 16.6 s 🟥 18.4 s ↑ +10 %
Code coverage Branch coverage 🟨 83.5 % 🟨 83.4 % ↓ +0 %
Lighthouse Minimizes main-thread work 🟥 19.5 s 🟥 25.3 s ↑ +30 %
Lighthouse Total Blocking Time 🟥 7,340 ms 🟥 10,660 ms ↑ +45 %
Lighthouse JavaScript execution time 🟥 9.6 s 🟥 11.7 s ↑ +22 %
Lighthouse Metrics 🟩 16638 🟩 18372 ↑ +10 %
Lighthouse Max Potential First Input Delay 🟥 3,170 ms 🟥 3,900 ms ↑ +23 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 1,786 KiB 🟩 Total size was 1,787 KiB ↑ +0 %
Lighthouse Uses efficient cache policy on static assets 🟨 27 resources found 🟨 27 resources found ↑ +0 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 105 KiB 🟥 Potential savings of 105 KiB ↓ −51 %
Lighthouse Initial server response time was short 🟩 Root document took 330 ms 🟩 Root document took 530 ms ↑ +63 %
Lighthouse Eliminate render-blocking resources 🟥 Potential savings of 1,380 ms 🟥 Potential savings of 1,520 ms ↑ +11 %
Lighthouse Server Backend Latencies 🟩 150 ms 🟩 290 ms ↑ +89 %
Lighthouse Network Round Trip Times 🟩 20 ms 🟩 70 ms ↑ +171 %
Lighthouse Avoids an excessive DOM size 🟥 2,192 elements 🟥 2,193 elements ↑ +0 %

490 other audits are unchanged.

@matejchalk matejchalk marked this pull request as ready for review July 22, 2024 10:15
@matejchalk matejchalk requested review from vmasek and BioPhoton July 22, 2024 10:15
Copy link
Collaborator

@BioPhoton BioPhoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!! the snapshot folder says thank you ;) Also nicer to debug.
WONDERFUL!

Copy link
Collaborator

@Tlacenka Tlacenka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@matejchalk matejchalk merged commit d45213d into main Jul 22, 2024
31 checks passed
@matejchalk matejchalk deleted the reduce-lint-rules-in-tests branch July 22, 2024 11:11
@BioPhoton
Copy link
Collaborator

BioPhoton commented Jul 27, 2024

I would say this is closing #255

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce number of lint rules in example app
3 participants