Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Big test data set in eslint plugin cause hard to debug tests #255

Closed
1 of 2 tasks
BioPhoton opened this issue Nov 14, 2023 · 0 comments
Closed
1 of 2 tasks

Big test data set in eslint plugin cause hard to debug tests #255

BioPhoton opened this issue Nov 14, 2023 · 0 comments
Labels
🧩 eslint-plugin 🧹 maintenance 🔬 testing writing tests
Milestone
4. Public

Comments

@BioPhoton
Copy link
Collaborator

BioPhoton commented Nov 14, 2023 •
edited
Loading

The tests already maintain ready folder structure and eslint rules. To make the tests more stable and easier to test I suggest:

  • reduce the data set to the minimum (number of used eslint rulse is 69 ATM which is not needed to test the functionality)
  • prefer to use expect.objectContains etc instead of snapshots to reduce tracked files and a more maintainable test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🧩 eslint-plugin 🧹 maintenance 🔬 testing writing tests
Projects
None yet
Milestone
4. Public
Development

No branches or pull requests
3 participants
@Tlacenka @BioPhoton @kristihoskova