Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocklist overhaul for testing #2098

Merged
merged 16 commits into from
May 5, 2024
Merged

Blocklist overhaul for testing #2098

merged 16 commits into from
May 5, 2024

Conversation

raszpl
Copy link
Contributor

@raszpl raszpl commented Mar 14, 2024

Dynamically updated on all pages, can turn on/off and see results live without reloading page. Channel blocklist works now where channel info available in thumbnail container.
Might still break on some subpages, needs more extensive testing.

@yagamiyakumo
Copy link

Sorry if this is the wrong place to ask, but how do I use the blocklist feature? There's a button to activate it but I don't see anyway to add channels into the blocklist

@raszpl
Copy link
Contributor Author

raszpl commented Mar 19, 2024

Sorry if this is the wrong place to ask, but how do I use the blocklist feature? There's a button to activate it but I don't see anyway to add channels into the blocklist

its half broken at the moment in official extension. Thats what Im trying to fix :)

WHEN USER

"the" is required, alternatively the word User can be left away too

I dont have strong opinions about this, just corrected according to common English grammar rules https://gallaudet.edu/student-success/tutorial-center/english-center/grammar-and-vocabulary/definite-and-indefinite-articles/when-to-use-a-an-or-the/

immediate application or VISUAL FEEDBACK when a SETTING IS MADE (not needed for pure CSS features, automated already)

In 4.804:
-Enable blocklist
-block a video
-disable blocklist
-enable blocklist

no visual feedback, no screen update
-go to blocklist > videos
-delete video you just blocked

again no updates on the screen

@ImprovedTube
Copy link
Member

looking forward to merge all your work!

just corrected according to common English grammar rules

💡
according to google results it's like:
"when the user clicks" 2.2 million
"when a user clicks" 1.x million
"when users click" 0.27 million (most accurate content actually?)
"when user clicks" 0.25 million (not little enough to be disregarded either)

+"when the user" 308 million
+"when a user" 102 million
+"when users" 73 million
+"when user" 11 million

@raszpl
Copy link
Contributor Author

raszpl commented May 4, 2024

heh, its been what, 2 months and its already stopped working, YT changed things around, for example Subscribe button on channel page is no longer 'YTD-SUBSCRIBE-BUTTON-RENDERER' but 'YT-SUBSCRIBE-BUTTON-VIEW-MODEL' :/

@raszpl
Copy link
Contributor Author

raszpl commented May 5, 2024

fixed it up and synced to master #2244

@ImprovedTube
Copy link
Member

hi! @raszpl
so YT- keeps catching up?
i got 'YT-SUBSCRIBE-BUTTON-VIEW-MODEL' is in the top of channel pages
and 'YTD-SUBSCRIBE-BUTTON-RENDERER' in the bottom.

@ImprovedTube ImprovedTube merged commit 3b817bf into code-charity:master May 5, 2024
@raszpl
Copy link
Contributor Author

raszpl commented May 6, 2024

I dont quite understand what was merged here :o It tells me both #2098 and #2244 got merged, but only one of those had fixed code ?!?! confusing github

i got 'YT-SUBSCRIBE-BUTTON-VIEW-MODEL' is in the top of channel pages and 'YTD-SUBSCRIBE-BUTTON-RENDERER' in the bottom.

I only see YTD-SUBSCRIBE-BUTTON-RENDERER on video pages
on channel page YT-SUBSCRIBE-BUTTON-VIEW-MODEL

parentNode of YTD-SUBSCRIBE-BUTTON-RENDERER had .__dataHost.__data.data containing all the stuff we are interested in, channel name etc. Those new buttons dont have any data associated with them, I had to switch to ytInitialData.metadata.channelMetadataRenderer

Its crashing on video pages now because it cant detect which one is channel, fix #2246

@raszpl raszpl deleted the BLOCKLIST branch May 6, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants