-
-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blocklist overhaul #2244
Blocklist overhaul #2244
Conversation
separate .it-blocklisted-channel
dynamically updated on all pages, can turn on/off and see results live without reloading page. Channel blocklist works now where channel info available in thumbnail container.
Blocklist
(didn't test it yet.) |
Yeah, this definitely needs testing, especially since I was monkey patching it to sync with current master. |
hi! @raszpl
i can accept PRs faster in future, or you can too or commit directly. 3b76c4b (undone: c76b129) can we avoid running anything without a feature enabled? Or else specific ID's like #subscribe-button might be enough. Update blocklist.js removing leftover debug code want to hoard all comments. To avoid ever walking the same path again. There are no disadvantages. As we can add a github action for minified releases, etc.) why is the margin gone to make the blocked items occupy less space? 4 rem is typically 64px |
neither one is mine?
can you be more specific? which code is being run without being enabled?
Main disadvantage is messy codebase full of outdated garbage. One of the main reasons for using git is ability to effortlessly peer into the past (with git-blame). There is no need to keep every piece of old code, its like hoarding used empty butter containers :-)
it was only working in side panel. Videos also show up in subscription feed, channel video pages etc. Afair it was screwing one of the other views. same as above, those were fixing some misalignment example https://www.youtube.com/@JanGarbacz/shorts block third video, Blocked description is cut in half |
No description provided.