Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocklist overhaul #2244

Merged
merged 18 commits into from
May 5, 2024
Merged

Blocklist overhaul #2244

merged 18 commits into from
May 5, 2024

Conversation

raszpl
Copy link
Contributor

@raszpl raszpl commented May 4, 2024

No description provided.

@ImprovedTube ImprovedTube merged commit 2c1ff0e into code-charity:master May 5, 2024
@ImprovedTube
Copy link
Member

(didn't test it yet.)

@raszpl
Copy link
Contributor Author

raszpl commented May 5, 2024

Yeah, this definitely needs testing, especially since I was monkey patching it to sync with current master.

@ImprovedTube
Copy link
Member

hi! @raszpl

to sync with current master

i can accept PRs faster in future, or you can too or commit directly.


3b76c4b (undone: c76b129) can we avoid running anything without a feature enabled? Or else specific ID's like #subscribe-button might be enough.


Update blocklist.js removing leftover debug code

Screenshot_722

want to hoard all comments. To avoid ever walking the same path again. There are no disadvantages. As we can add a github action for minified releases, etc.)

Screenshot_723

why is the margin gone to make the blocked items occupy less space?

4 rem is typically 64px

3631b80

0745880

@raszpl
Copy link
Contributor Author

raszpl commented May 15, 2024

3b76c4b (undone: c76b129)

neither one is mine?

can we avoid running anything without a feature enabled? Or else specific ID's like #subscribe-button might be enough.

can you be more specific? which code is being run without being enabled?

Update blocklist.js removing leftover debug code

want to hoard all comments. To avoid ever walking the same path again. There are no disadvantages.

Main disadvantage is messy codebase full of outdated garbage. One of the main reasons for using git is ability to effortlessly peer into the past (with git-blame). There is no need to keep every piece of old code, its like hoarding used empty butter containers :-)

why is the margin gone to make the blocked items occupy less space?
4 rem is typically 64px

it was only working in side panel. Videos also show up in subscription feed, channel video pages etc. Afair it was screwing one of the other views.

3631b80

same as above, those were fixing some misalignment

example https://www.youtube.com/@JanGarbacz/shorts block third video, Blocked description is cut in half

ImprovedTube added a commit that referenced this pull request Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants