focus issue fixed #2204
Merged
focus issue fixed #2204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Currently if I don't use the keyboard, it still shows that the first menu item is selected. I think the ideal behaviour is if I first click upload button / click a + u to open, nothing is shown as selected. When I hover / hit down button, then the first button is shown as selected. Not sure if this was what we wanted? @percyliang @epicfaace |
adiprerepa
pushed a commit
that referenced
this pull request
May 27, 2021
* focus issue fixed * hide content for accessibility Co-authored-by: yipenghe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #2170