Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focusing issue with the upload button #2170

Closed
yipenghe opened this issue Apr 16, 2020 · 3 comments · Fixed by #2204
Closed

Focusing issue with the upload button #2170

yipenghe opened this issue Apr 16, 2020 · 3 comments · Fixed by #2204
Assignees

Comments

@yipenghe
Copy link
Member

yipenghe commented Apr 16, 2020

When you click on the upload button in the header, it opens up the upload menu. However, it auto focuses on the first menu item even if I'm not hovering on the menu.
Screenshot from 2020-04-15 23-52-49
When my mouse hovers around the second upload item, it adds shades to the item, but the first menu still has a blue "selected" color, which is confusing

Screenshot from 2020-04-15 23-55-45

The ideal behaviour would be to not auto-select the first menu item after clicking

@Levilian
Copy link
Contributor

mui/material-ui#5186 The multiple state seems quite common. It's indeed an UI problem.

@Levilian
Copy link
Contributor

Levilian commented Apr 23, 2020

The temporary fix is to reduce the confusion on the user end by having the default item to be a placeholder with style display: "none"

@Levilian
Copy link
Contributor

Levilian commented Apr 30, 2020

The temporary fix is to reduce the confusion on the user end by having the default item to be a placeholder with style display: "none"

The issue with using display: "none" is that it makes the element inaccessible to screen readers and keyboard users. Therefore, we resort to the method described here to manually make an invisible element.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants