fix: Improve robustness when building Codacy API base URL #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By using the java.net.URL constructor we ensure that the version path "/2.0" is always appended after the authority component of the URL.
prcr
commented
Jan 18, 2021
| @@ -25,7 +26,7 @@ class CodacyClient( | |||
| apiToken.map(t => "api_token" -> t) ++ | |||
| projectToken.map(t => "project_token" -> t) | |||
|
|
|||
| private val remoteUrl = apiUrl.getOrElse("https://api.codacy.com") + "/2.0" | |||
| private val remoteUrl = new URL(new URL(apiUrl.getOrElse("https://api.codacy.com")), "/2.0").toString() | |||
There was a problem hiding this comment.
@lolgab, perhaps you have a suggestion on how to do this in a more "Scala way"? 😄
We should also have some error handling here in case the URL coming from user input is malformed. 🤔 Can you help?
There was a problem hiding this comment.
I guess this is fine.. I was thinking about files, that's why I told you there was a "Scala way" to interpolate 😄
I'm merging this one.
lolgab
approved these changes
Jan 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On codacy/docs#404 a user noticed that the upload fails if the defined
CODACY_API_BASE_URLenvironment variable includes a trailing slash character (/).By using the java.net.URL constructor we ensure that the version path "/2.0" is always appended after the authority component of the URL.