Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS-190] Feedback on "Adding coverage to your repository" #404

Closed
1 of 5 tasks
aarongoldenthal opened this issue Jan 11, 2021 · 3 comments
Closed
1 of 5 tasks

[DOCS-190] Feedback on "Adding coverage to your repository" #404

aarongoldenthal opened this issue Jan 11, 2021 · 3 comments
Assignees
Labels
bug Invalid information or something isn't working missing info Missing information

Comments

@aarongoldenthal
Copy link

Type of feedback

  • Bug or incorrect information
  • Missing information
  • Outdated information
  • Enhancement
  • Other

Feedback

The CODACY_API_BASE_URL must not end in "/" (e.g. https://codacy.somwhere.com vs https://codacy.somwhere.com/) or the upload fails with the error:

Error [CodacyCoverageReporter] Failed to upload coverage report /builds/my-project/opencover.xml: Request URL not found. Check if the project API Token you are using and the API base URL are valid.  - (CodacyCoverageReporter.scala:25)

This should at least be clarified in the documentation, although one could argue this is a big that the code should handle gracefully.

Affected pages
This feedback applies to the following documentation pages / URLs:

https://docs.codacy.com/coverage-reporter/adding-coverage-to-your-repository/

@github-actions
Copy link
Contributor

Internal Jira issue: DOCS-190

@github-actions github-actions bot changed the title Feedback on "Adding coverage to your repository" [DOCS-190] Feedback on "Adding coverage to your repository" Jan 11, 2021
@prcr prcr self-assigned this Jan 11, 2021
@prcr prcr added bug Invalid information or something isn't working missing info Missing information labels Jan 11, 2021
@prcr
Copy link
Contributor

prcr commented Jan 21, 2021

Thank you @aarongoldenthal for providing this feedback.

We're working on letting the Codacy Coverage Reporter accept URLs with the trailing slash, so we don't have to ask users to leave it out. In the meanwhile, I'll leave this issue open until we release the fix. 👍

@prcr prcr added the in progress The issue is being worked on label Jan 21, 2021
@prcr
Copy link
Contributor

prcr commented Jan 27, 2021

The Codacy Coverage Reporter now accepts the CODACY_API_BASE_URL even if it includes a trailing slash (/) since version 11.7.3.

@prcr prcr closed this as completed Jan 27, 2021
@prcr prcr removed the in progress The issue is being worked on label Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Invalid information or something isn't working missing info Missing information
Projects
None yet
Development

No branches or pull requests

2 participants