env: Add clearerr() before repeating an interrupted file read #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change updates PosixSequentialFile::Read to call clearerr() before fread()ing again after an EINTR is returned on a previous fread. Proactive fix for facebook#6509
petermattis
approved these changes
Mar 11, 2020
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @petermattis and @sumeerbhola)
|
CI is really flakey; the main tests are passing, but the java ones are failing with this error: I'll just merge as-is |
itsbilal
added a commit
to itsbilal/cockroach
that referenced
this pull request
Mar 12, 2020
Bumps rocksdb ref to pick up cockroachdb/rocksdb#75 Bumps pebble ref to pick up SeqNum fix and standardization of initial and last SeqNum handling with RocksDB. New pebble revision is d2ecbc248decea8d177e2d2777d8ef458267eddc Release note: None
craig bot
pushed a commit
to cockroachdb/cockroach
that referenced
this pull request
Mar 12, 2020
45986: roachtest: adjust tpchvec r=yuzefovich a=yuzefovich Release justification: non-production code change. This commit unskips query 9 and removes some code that was put in place to handle missing disk spilling in the vectorized engine. Release note: None 46009: sql: add telemetry for window functions r=yuzefovich a=yuzefovich **sql: remove some unused code** Release justification: non-production code changes. This code is no longer needed since the optimizer took over planning of the window functions. Release note: None **sql: add telemetry for window functions** Release justification: telemetry change. Fixes: #45598. Release note: None 46032: vendor, rocksdb: Bump rocksdb and pebble refs r=itsbilal a=itsbilal Bumps rocksdb ref to pick up cockroachdb/rocksdb#75 Bumps pebble ref to pick up SeqNum fix and standardization of initial and last SeqNum handling with RocksDB. New pebble revision is d2ecbc248decea8d177e2d2777d8ef458267eddc Release note: None 46036: sqltelemetry: adjust IAM telemetry methods to have Inc/Counter r=RichardJCai a=otan Trying to standardise the sqltelemetry package such that every name ends with `Counter`, so this is a `sed` replace to do just that. Also noticed that `IAMAlter` has a different name, so fixing that form too. Release justification: Refactoring of names only. Release note: None Co-authored-by: Yahor Yuzefovich <[email protected]> Co-authored-by: Bilal Akhtar <[email protected]> Co-authored-by: Oliver Tan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates PosixSequentialFile::Read to call clearerr()
before fread()ing again after an EINTR is returned on a previous
fread.
Proactive fix for facebook#6509
This change is