vendor, rocksdb: Bump rocksdb and pebble refs #46032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps rocksdb ref to pick up cockroachdb/rocksdb#75 Bumps pebble ref to pick up SeqNum fix and standardization of initial and last SeqNum handling with RocksDB. New pebble revision is d2ecbc248decea8d177e2d2777d8ef458267eddc Release note: None
|
This change is |
petermattis
approved these changes
Mar 12, 2020
There was a problem hiding this comment.
LGTM
FYI, I usually run git log --oneline --no-merges <old-sha>..<new-sha> to get the info for the commit message, and then do some manual massaging to replace the sha on each line with *. What you're doing is fine too, but can become burdensome as they number of changes increases.
|
Thanks for the review! And yes, I usually do something like that when there are multiple changes, but right now it was one change each that I authored so it was easiest to just type it out of memory. bors R+ |
|
bors r+ |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps rocksdb ref to pick up cockroachdb/rocksdb#75
Bumps pebble ref to pick up SeqNum fix and standardization of initial
and last SeqNum handling with RocksDB. New pebble revision is
d2ecbc248decea8d177e2d2777d8ef458267eddc
Release note: None