Disable TLS for MINGW due to issues with the order of freeing up memory. #57
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be an issue with the way MINGW frees up TLS memory. More specifically - the TLS is freed up before the destructors on the objects residing in TLS are called. In our case - we were observing a destructor accessing a block of memory that was already freed.
Here is a report from end uses that seems to be related https://sourceforge.net/p/mingw-w64/bugs/727/
Fixes cockroachdb/cockroach#40936
Fixes cockroachdb/cockroach#40925
This change is