Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cockroach quit doesn't work on windows #40925

Closed
darinpp opened this issue Sep 19, 2019 · 0 comments · Fixed by #40994
Closed

cockroach quit doesn't work on windows #40925

darinpp opened this issue Sep 19, 2019 · 0 comments · Fixed by #40994
Labels
A-kv Anything in KV that doesn't belong in a more specific category. B-os-windows Issues specific to the Windows OS. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. S-2 Medium-high impact: many users impacted, risks of availability and difficult-to-fix data errors

Comments

@darinpp
Copy link
Contributor

darinpp commented Sep 19, 2019

Describe the problem

Shutting down a node with cockroach quit doesn't work when the server is running on Windows. The server stops responding but doesn't exist and the only way to terminate it is with Task Manager.

To Reproduce

  1. Start cockroach.exe start-single-node --insecure
    2 Run cockroach.exe quit --insecure and confirm that you get OK
    3 Verify that the node didn't terminate and that you can't connect to it anymore.

Another way to try to terminate the process is to press Ctrl-C in a terminal window. This has the same result. The node doesn't terminate and stops responding. The only way to terminate it is with Task Manager.

Expected behavior
I expect the node process to terminate.

Additional data / screenshots

Environment:

  • CockroachDB version [CCL v19.2.0-alpha.20190606-2275-g16af2ea-dirty @ 2019/09/18 15:49:54 (go1.12.5)]
  • Server OS: [Microsoft Windows [Version 10.0.18362.356]]
  • Client app [N/A]

Additional context
@darinpp darinpp added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. B-os-windows Issues specific to the Windows OS. S-2 Medium-high impact: many users impacted, risks of availability and difficult-to-fix data errors A-kv Anything in KV that doesn't belong in a more specific category. labels Sep 19, 2019
@darinpp darinpp mentioned this issue Sep 23, 2019
Merged
@darinpp darinpp mentioned this issue Sep 23, 2019
Merged
craig bot pushed a commit that referenced this issue Sep 23, 2019
@darinpp
Merge #40994
86c6ab3 
40994: c-deps: bump rocksdb to disable TLS on Windows r=darinpp a=darinpp

Release justification: There is a bug related to freeing up
TLS memory. It results in accessing freed up memory at shutdown.
This fixes it.

Fixes #40925
Fixes #40936

Release note: Resolves an issue with shutting down a node with
`cockroach quit` when the server is running on Windows leads to
the server process hanging.

Co-authored-by: Darin <[email protected]>
@craig craig bot closed this as completed in ab10150 Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-kv Anything in KV that doesn't belong in a more specific category. B-os-windows Issues specific to the Windows OS. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. S-2 Medium-high impact: many users impacted, risks of availability and difficult-to-fix data errors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

c-deps: bump rocksdb to disable TLS on Windows darinpp/cockroach
1 participant
@darinpp