sstable: make Category an enum #4119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Instead of using arbitrary strings, we use an enum. Categories must now be registered upfront (from an `init` function). We also associate the QoS level upon registration, simplifying the plumbing.
|
cockroachdb/cockroach#133643 is a draft of the CRDB-side change. |
jbowens
approved these changes
Nov 1, 2024
There was a problem hiding this comment.
Reviewed 16 of 16 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @RaduBerinde)
|
TFTR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using arbitrary strings, we use an enum. Categories must
now be registered upfront (from an
initfunction). We also associatethe QoS level upon registration, simplifying the plumbing.